Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] [email protected] #16161

Merged
merged 6 commits into from
Oct 11, 2022
Merged

[FLASK] [email protected] #16161

merged 6 commits into from
Oct 11, 2022

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Oct 11, 2022

Explanation

Bumps Snaps packages to 0.22.2, fixing a few smaller issues.

The primary goal of this PR is to fix an issue with installing snaps that request eth_accounts.

To create the eth_accounts permission, we need the selected accounts from the UI, these are normally passed back in the result of the approval (see https://github.com/MetaMask/metamask-extension/blob/develop/ui/components/app/permission-page-container/permission-page-container.component.js#L90-L109).

The SnapController in 0.22.2 supports that, so we make the appropriate change to pass that information back.

Manual Testing Steps

  1. Create a template snap that uses eth_accounts
  2. Install it and see that it successfully installs
  3. Try develop and see that it fails to install there

@metamaskbot
Copy link
Collaborator

Builds ready [55c1b33]
Page Load Metrics (2391 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint933781336330
domContentLoaded21602600234613464
load21812678239113665
domInteractive21602600234613464

@danjm danjm added this to the v10.21.0 milestone Oct 11, 2022
@FrederikBolding FrederikBolding merged commit d640c9a into develop Oct 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants