Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] Fix crash when uninstalling snap #15799

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

FrederikBolding
Copy link
Member

Explanation

Fixes a crash that would happen when uninstalling a snap from the settings page.

Manual Testing Steps

  1. Install any snap.
  2. Visit its settings page
  3. Uninstall the snap
  4. Verify that MM has not crashed

@FrederikBolding FrederikBolding requested a review from a team as a code owner September 12, 2022 17:24
@metamaskbot
Copy link
Collaborator

Builds ready [a5eb7f1]
Page Load Metrics (1767 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1002551293416
domContentLoaded15922223174613766
load15922223176714469
domInteractive15922223174613766

highlights:

storybook

@FrederikBolding FrederikBolding merged commit 6cd18ea into develop Sep 13, 2022
@FrederikBolding FrederikBolding deleted the fb/fix-settings-crash-2 branch September 13, 2022 10:41
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants