Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] Fix crash with certain permissions on the snap settings page #15797

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

FrederikBolding
Copy link
Member

Explanation

Fixes a crash that would happen when viewing the settings page with a snap that uses snap_getBip32Entropy.

Manual Testing Steps

  1. Install a snap that uses snap_getBip32Entropy
  2. Visit its settings page
  3. Verify that you can see the snap permissions

@metamaskbot
Copy link
Collaborator

Builds ready [dbfd1ac]
Page Load Metrics (1671 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint95143109147
domContentLoaded1530174816417034
load1530191816719546
domInteractive1530174816417034

highlights:

storybook

@FrederikBolding FrederikBolding merged commit 398b93c into develop Sep 12, 2022
@FrederikBolding FrederikBolding deleted the fb/fix-settings-permissions branch September 12, 2022 16:36
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants