Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Rinkeby with Goerli for dev testing #15781

Merged
merged 3 commits into from
Sep 12, 2022

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Sep 9, 2022

Explanation

Replaces Rinkeby with Goerli for dev testing in Swaps.

Manual Testing Steps

  • Run yarn start for dev mode. Rinkeby will be disabled and Goerli enabled for Swaps

@dan437 dan437 requested a review from a team as a code owner September 9, 2022 14:44
@dan437 dan437 requested a review from segun September 9, 2022 14:44
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Member

@kumavis kumavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not familiar with this part of the code base but the change seems reasonable

@dan437 dan437 merged commit 34e2faa into MetaMask:develop Sep 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2022
@dan437 dan437 deleted the rinkeby-to-goerli-dev-testing branch July 24, 2023 11:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants