[e2e] Fix Dapp interactions flaky test on chrome #16282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Dapp interactions testcase is flaky and failing more often recently on chrome, due to trying to switch to MM Notification popup before being displayed.
This PR fixes it by waiting until we have 4 windows on the
getAllWindowsHandles
.Screenshots/Screencaps
Before
See failures, as only 3 windows were present at that time (added logs for clarity)
After
See successful test, now waits for 4 windows.
Manual Testing Steps
yarn build:test
yarn test:e2e:single test/e2e/tests/dapp-interactions.spec.js --browser=chrome
Pre-Merge Checklist
+ If there are functional changes: