Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Fix Dapp interactions flaky test on chrome #16282

Merged
merged 2 commits into from
Oct 26, 2022
Merged

[e2e] Fix Dapp interactions flaky test on chrome #16282

merged 2 commits into from
Oct 26, 2022

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Oct 26, 2022

Explanation

Dapp interactions testcase is flaky and failing more often recently on chrome, due to trying to switch to MM Notification popup before being displayed.

This PR fixes it by waiting until we have 4 windows on the getAllWindowsHandles.

Screenshots/Screencaps

Before

See failures, as only 3 windows were present at that time (added logs for clarity)
image

After

See successful test, now waits for 4 windows.
image

Manual Testing Steps

  1. Build test yarn build:test
  2. Run the flaky test on chrome yarn test:e2e:single test/e2e/tests/dapp-interactions.spec.js --browser=chrome

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@seaona seaona requested a review from a team as a code owner October 26, 2022 12:19
@seaona seaona requested a review from NidhiKJha October 26, 2022 12:19
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona changed the title Fix Dapp interactions flaky test [e2e] Fix Dapp interactions flaky test on chrome Oct 26, 2022
@seaona seaona self-assigned this Oct 26, 2022
@seaona seaona added the needs-qa Label will automate into QA workspace label Oct 26, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [b876940]
Page Load Metrics (2223 ± 112 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint842226218461221
domContentLoaded176625872196217104
load176627082223233112
domInteractive176625872196217104

@jpuri jpuri merged commit c519d3e into develop Oct 26, 2022
@jpuri jpuri deleted the e2e-flaky-fix branch October 26, 2022 14:19
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-qa Label will automate into QA workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants