Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue rm enzyme, unit tests. #15730

Merged
merged 6 commits into from
Sep 8, 2022
Merged

Continue rm enzyme, unit tests. #15730

merged 6 commits into from
Sep 8, 2022

Conversation

tmashuang
Copy link
Contributor

Convert Confirm Page Container and Welcome components to use testing-library/react, and adds test-ids to elements associated with those tests.

@tmashuang tmashuang requested a review from a team as a code owner August 31, 2022 22:31
@tmashuang tmashuang requested a review from digiwand August 31, 2022 22:31
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tmashuang tmashuang changed the title Rm enzyme Continue rm enzyme, unit tests. Aug 31, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [8f7e7f1]
Page Load Metrics (1797 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint981731182010
domContentLoaded15912082176210249
load16362106179710651
domInteractive15912082176210249

highlights:

storybook

darkwing
darkwing previously approved these changes Sep 1, 2022
View reviewed changes
brad-decker
brad-decker previously approved these changes Sep 5, 2022
View reviewed changes
digiwand
digiwand previously approved these changes Sep 5, 2022
View reviewed changes
@tmashuang tmashuang dismissed stale reviews from brad-decker and darkwing via 9624b17 September 5, 2022 20:36
@metamaskbot
Copy link
Collaborator

Builds ready [9624b17]
Page Load Metrics (1974 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1071782220360173
domContentLoaded17382403194717283
load17382403197416479
domInteractive17382403194717283

highlights:

storybook

@metamaskbot
Copy link
Collaborator

Builds ready [32b4d0e]
Page Load Metrics (1679 ± 29 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92135108136
domContentLoaded1585181716695928
load1598183516796029
domInteractive1585181716695928

highlights:

storybook

@metamaskbot
Copy link
Collaborator

Builds ready [3191a20]
Page Load Metrics (1711 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint971811182010
domContentLoaded1569184016957235
load1569184417117636
domInteractive1569184016957235

highlights:

storybook

@tmashuang tmashuang requested a review from digiwand September 8, 2022 03:02
@tmashuang tmashuang merged commit c2218ad into develop Sep 8, 2022
@tmashuang tmashuang deleted the rm-enzyme branch September 8, 2022 17:05
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@digiwand digiwand digiwand approved these changes

@brad-decker brad-decker brad-decker approved these changes

@darkwing darkwing Awaiting requested review from darkwing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tmashuang @metamaskbot @darkwing @brad-decker @digiwand