Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make createSpeedUpTransaction action idempotent #15688

Merged
merged 8 commits into from
Sep 13, 2022
Merged

Make createSpeedUpTransaction action idempotent #15688

merged 8 commits into from
Sep 13, 2022

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Aug 24, 2022

Fixes: #15542

Make createSpeedUpTransaction action idempotent.

@jpuri jpuri requested a review from a team as a code owner August 24, 2022 12:25
@jpuri jpuri requested review from danjm and removed request for a team August 24, 2022 12:25
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [7987858]
Page Load Metrics (1782 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint912091282914
domContentLoaded16362150175311656
load16622150178211354
domInteractive16362150175311656

highlights:

storybook

segun
segun previously approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@segun segun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hilvmason hilvmason added the PR - P1 identifies PRs deemed priority for Extension team label Aug 25, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [4138cc6]
Page Load Metrics (1622 ± 33 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint87130103136
domContentLoaded1528168416055627
load1531179016226933
domInteractive1528168416055627

highlights:

storybook

@jpuri jpuri requested a review from digiwand September 7, 2022 12:04
@metamaskbot
Copy link
Collaborator

Builds ready [855bcf2]
Page Load Metrics (1781 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint101159125157
domContentLoaded16011982177310952
load16011982178111254
domInteractive16011982177310952

highlights:

storybook

brad-decker
brad-decker previously requested changes Sep 8, 2022
View reviewed changes
app/scripts/controllers/transactions/index.js Outdated Show resolved Hide resolved
@jpuri jpuri requested review from brad-decker and segun September 8, 2022 18:32
@jpuri jpuri force-pushed the make_cancel_tran_idempotent branch from 0b51969 to c5b70b9 Compare September 8, 2022 18:53
@jpuri jpuri requested a review from kumavis as a code owner September 8, 2022 18:53
@jpuri jpuri force-pushed the make_cancel_tran_idempotent branch from 3e636f5 to 6d1f418 Compare September 8, 2022 18:59
@jpuri jpuri force-pushed the make_speedup_transaction_idempotent branch from befc09d to c2a57ed Compare September 8, 2022 19:07
@metamaskbot
Copy link
Collaborator

Builds ready [8760560]
Page Load Metrics (1906 ± 91 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint991951312512
domContentLoaded16272177186916278
load16282253190618991
domInteractive16272177186916278

highlights:

storybook

Base automatically changed from make_cancel_tran_idempotent to develop September 9, 2022 11:50
@jpuri jpuri requested a review from digiwand September 9, 2022 11:51
@metamaskbot
Copy link
Collaborator

Builds ready [df05ea0]
Page Load Metrics (1794 ± 97 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint951821272412
domContentLoaded15822348177820196
load15822349179420297
domInteractive15822348177820196

highlights:

storybook

@jpuri jpuri dismissed brad-decker’s stale review September 12, 2022 13:04

Suggested changes have been implemented.

@jpuri jpuri merged commit 0b1744d into develop Sep 13, 2022
@jpuri jpuri deleted the make_speedup_transaction_idempotent branch September 13, 2022 12:43
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@digiwand digiwand digiwand approved these changes

@darkwing darkwing darkwing approved these changes

@danjm danjm Awaiting requested review from danjm danjm is a code owner automatically assigned from MetaMask/extension-devs

@brad-decker brad-decker Awaiting requested review from brad-decker

@segun segun Awaiting requested review from segun

@kumavis kumavis Awaiting requested review from kumavis

Assignees
No one assigned
Labels
PR - P1 identifies PRs deemed priority for Extension team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make createSpeedUpTransaction action idempotent
7 participants
@jpuri @metamaskbot @segun @darkwing @brad-decker @digiwand @hilvmason