Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring Blockies Icon is used in nickname popup when enabled #15768

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Sep 8, 2022

Fixes: #15764

Component was being directly imported as opposed to the containerized import

Test Plan

Defined in issue

Screen Shot 2022-09-08 at 10 57 09 AM

Screen Shot 2022-09-08 at 10 56 37 AM

@ryanml ryanml self-assigned this Sep 8, 2022
@ryanml ryanml requested a review from a team as a code owner September 8, 2022 17:59
@ryanml ryanml requested a review from garrettbear September 8, 2022 17:59
@metamaskbot
Copy link
Collaborator

Builds ready [14a8bd7]
Page Load Metrics (1937 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1113161504421
domContentLoaded17642184190811756
load17652184193711153
domInteractive17642184190811756

highlights:

storybook

@ryanml ryanml merged commit 82cf63f into develop Sep 8, 2022
@ryanml ryanml deleted the fix-15764 branch September 8, 2022 20:01
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Blockies identicon is not displayed on Add/Edit Nickname when option is enabled
4 participants