Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable "Add Popular Network" feature by default for all users #16172

Merged
merged 8 commits into from
Oct 27, 2022
Merged

Enable "Add Popular Network" feature by default for all users #16172

merged 8 commits into from
Oct 27, 2022

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Oct 12, 2022

Fixes: #16016

More Information

  • Removes code related to enabling/disabling the "Add Popular Network" feature
  • Persists the feature for all users
  • Removes "What's New" notification which prompted users to turn on the setting
  • Removes the Experimental toggle for "Add Popular Network"

Manual Testing Steps

  1. Ensure all paths to adding a network show the Popular networks that can be added
  2. Ensure the Experimental toggle is no longer available
  3. Ensure the old "What's New" notification does not show

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@ryanml ryanml added this to the v10.21.0 milestone Oct 12, 2022
@ryanml ryanml self-assigned this Oct 12, 2022
@ryanml ryanml requested a review from a team as a code owner October 12, 2022 18:07
@ryanml ryanml requested a review from NiranjanaBinoy October 12, 2022 18:07
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

jpuri
jpuri previously approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

darkwing
darkwing previously approved these changes Oct 24, 2022
View reviewed changes
@danjm danjm dismissed stale reviews from darkwing and jpuri via d88e894 October 25, 2022 05:06
@metamaskbot
Copy link
Collaborator

Builds ready [92abddb]
Page Load Metrics (2269 ± 97 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint882479221518249
domContentLoaded17332590223518790
load17532654226920197
domInteractive17332590223518790

highlights:

storybook

@danjm danjm merged commit 6c84e96 into develop Oct 27, 2022
@danjm danjm deleted the change-16016 branch October 27, 2022 10:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danjm danjm danjm approved these changes

@jpuri jpuri jpuri approved these changes

@darkwing darkwing darkwing left review comments

@NiranjanaBinoy NiranjanaBinoy Awaiting requested review from NiranjanaBinoy NiranjanaBinoy is a code owner automatically assigned from MetaMask/extension-devs

Assignees

@ryanml ryanml

Labels
rc-cherry-picked
Projects
None yet
Milestone
v10.21.0
Development

Successfully merging this pull request may close these issues.

Turn the add popular network feature on by default to users 🎉
6 participants
@ryanml @metamaskbot @darkwing @jpuri @danjm @seaona