Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only render tooltip component if swap network is disabled #15733

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Sep 1, 2022

The "swaps" button on the home and token overview screens focus twice on Swap, which is sort of annoying. This PR fixes the issue

Screenshots/Screencaps

tabindex

Manual Testing Steps

Tab through the home screen, ensure Swaps is only focused once.

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@darkwing darkwing requested a review from a team as a code owner September 1, 2022 15:55
@darkwing darkwing requested a review from segun September 1, 2022 15:55
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [f6b57d3]
Page Load Metrics (2053 ± 97 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1061827229367176
domContentLoaded17092466200820699
load17922500205320297
domInteractive17092466200820699

@darkwing darkwing merged commit e8232aa into develop Sep 9, 2022
@darkwing darkwing deleted the avoid-double-outline branch September 9, 2022 19:12
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants