Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making addPermittedAccount and removePermittedAccount methods idempotent #15709

Merged
merged 5 commits into from
Sep 6, 2022

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Aug 25, 2022

Fixes #15708

Making addPermittedAccount and removePermittedAccount methods idempotent.

@jpuri jpuri requested a review from a team as a code owner August 25, 2022 12:06
@jpuri jpuri requested a review from Gtonizuka August 25, 2022 12:06
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@hilvmason hilvmason added the PR - P1 identifies PRs deemed priority for Extension team label Aug 25, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [9e3e6ad]
Page Load Metrics (1856 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1003261324722
domContentLoaded16022074182310551
load1717207418569345
domInteractive16022074182310551

NiranjanaBinoy
NiranjanaBinoy previously approved these changes Aug 25, 2022
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpuri jpuri dismissed stale reviews from NiranjanaBinoy and ghost via 2c47369 September 5, 2022 15:22
@jpuri jpuri requested review from digiwand, JurbinM and NiranjanaBinoy and removed request for JurbinM September 5, 2022 15:23
@metamaskbot
Copy link
Collaborator

Builds ready [2c47369]
Page Load Metrics (1969 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1032931423818
domContentLoaded17452305193913464
load17702332196914168
domInteractive17452305193913464

@metamaskbot
Copy link
Collaborator

Builds ready [f74701a]
Page Load Metrics (1816 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint981988219406195
domContentLoaded16531992179910450
load16622074181612761
domInteractive16531992179910450

Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems OK to me. In retrospect, an error here seems a bit harsh, IMO.

@jpuri jpuri merged commit 8c8539d into develop Sep 6, 2022
@jpuri jpuri deleted the permission_controller_methods_idempotent branch September 6, 2022 19:47
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR - P1 identifies PRs deemed priority for Extension team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make permissionController methods: addPermittedAccount and removePermittedAccount idempotent
7 participants