-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making addPermittedAccount and removePermittedAccount methods idempotent #15709
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [9e3e6ad]
Page Load Metrics (1856 ± 45 ms)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… permission_controller_methods_idempotent
Co-authored-by: Ariella Vu <[email protected]>
Builds ready [2c47369]
Page Load Metrics (1969 ± 68 ms)
|
Builds ready [f74701a]
Page Load Metrics (1816 ± 61 ms)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems OK to me. In retrospect, an error here seems a bit harsh, IMO.
Fixes #15708
Making addPermittedAccount and removePermittedAccount methods idempotent.