Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Chromedriver to the last version #15798

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Updating Chromedriver to the last version #15798

merged 3 commits into from
Sep 13, 2022

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Sep 12, 2022

Explanation

Update Chromedriver and Chrome to last stable version for e2e tests.

More Information

https://www.ubuntuupdates.org/ppa/google_chrome?dist=stable

Screenshots/Screencaps

Before

"chromedriver": "^103.0.0",
CHROME_VERSION='103.0.5060.53-1'

After

"chromedriver": "^105.0.0",
CHROME_VERSION='105.0.5195.102-1'

Manual Testing Steps

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@seaona seaona requested a review from a team as a code owner September 12, 2022 16:05
@seaona seaona requested a review from hmalik88 September 12, 2022 16:05
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona requested a review from kumavis as a code owner September 12, 2022 16:44
@metamaskbot
Copy link
Collaborator

Builds ready [ff79925]
Page Load Metrics (1258 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint901229162245118
domContentLoaded1162133612435627
load1162138512586832
domInteractive1162133612435627

@seaona seaona self-assigned this Sep 13, 2022
@seaona seaona added the needs-qa Label will automate into QA workspace label Sep 13, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [b364f98]
Page Load Metrics (1217 ± 26 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint84131101136
domContentLoaded1123135012025928
load1123135012175426
domInteractive1123135012025928

@seaona seaona merged commit d322c89 into develop Sep 13, 2022
@seaona seaona deleted the chromedriver-update branch September 13, 2022 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-qa Label will automate into QA workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants