Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: make mypy pass in all services/packages in repo #4071

Closed
3 tasks done
pcrespov opened this issue Apr 6, 2023 · 3 comments
Closed
3 tasks done

Maintenance: make mypy pass in all services/packages in repo #4071

pcrespov opened this issue Apr 6, 2023 · 3 comments
Assignees
Labels
t:maintenance Some planned maintenance work
Milestone

Comments

@pcrespov
Copy link
Member

pcrespov commented Apr 6, 2023

  1. make mypy and fix all errors
  2. add typecheck step in .github/workflows/ci-testing-deploy.yml before test step as
      - name: typecheck
        run: ./ci/github/unit-testing/api-server.bash typecheck
      - name: test
        if: always()  <----- NOTE!
        run: ./ci/github/unit-testing/api-server.bash test
  1. add mypy files filter in your services
      - uses: dorny/paths-filter@v2
        id: filter
        with:
          filters: 
              - 'scripts/mypy/*'
              - 'mypy.ini'

Distribution of tasks

Tasks

  1. t:maintenance
    matusdrobuliak66
  2. t:maintenance
    matusdrobuliak66
  3. t:maintenance
    pcrespov
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Apr 6, 2023
@pcrespov pcrespov added this to the Jelly Beans milestone Apr 6, 2023
@mrnicegyu11 mrnicegyu11 changed the title Maintenance: extend mypy to all services/packages in repo Maintenance: make mypy pass in all services/packages in repo Apr 11, 2023
@mrnicegyu11
Copy link
Member

Follow-Up: Once mypy is sufficiently happy it should be added to the CI :) gracias!

@GitHK
Copy link
Contributor

GitHK commented Apr 12, 2023

dynamic-sidecar already has the checks in place

@pcrespov pcrespov modified the milestones: Jelly Beans, Watermelon Jun 8, 2023
@pcrespov pcrespov modified the milestones: Watermelon, Sundae Jul 21, 2023
@matusdrobuliak66
Copy link
Contributor

Thanks to good teamwork effort, I can officially close this issue 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

No branches or pull requests

5 participants