Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ director-v2 fixing mypy issues part 1/3 #4100

Merged
merged 15 commits into from
Apr 18, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Apr 13, 2023

What do these changes do?

Since there are lots of changes to be made in this service. Starting with a first round.

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK self-assigned this Apr 13, 2023
@GitHK GitHK added t:maintenance Some planned maintenance work changelog:♻️refactor labels Apr 13, 2023
@GitHK GitHK added this to the Jelly Beans milestone Apr 13, 2023
@GitHK GitHK changed the title ♻️ director-v2 mypy changes (first round) ♻️ director-v2 fixing mypy issues (first round) Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #4100 (c37f442) into master (49ee3cd) will decrease coverage by 13.3%.
The diff coverage is 94.8%.

❗ Current head c37f442 differs from pull request most recent head 06dbb7e. Consider uploading reports for the commit 06dbb7e to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4100      +/-   ##
=========================================
- Coverage    85.4%   72.2%   -13.3%     
=========================================
  Files         953     390     -563     
  Lines       41364   20261   -21103     
  Branches      957     174     -783     
=========================================
- Hits        35345   14638   -20707     
+ Misses       5801    5574     -227     
+ Partials      218      49     -169     
Flag Coverage Δ
integrationtests 66.4% <73.7%> (-0.3%) ⬇️
unittests 86.3% <93.5%> (+4.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._director_v2/modules/db/repositories/comp_tasks.py 96.7% <ø> (ø)
...es/dynamic_sidecar/docker_compose_egress_config.py 56.7% <0.0%> (ø)
...ice_director_v2/modules/dynamic_sidecar/volumes.py 70.0% <0.0%> (-1.5%) ⬇️
...e_service_director_v2/api/dependencies/rabbitmq.py 60.0% <50.0%> (-15.0%) ⬇️
...-v2/src/simcore_service_director_v2/core/errors.py 76.7% <87.5%> (-0.3%) ⬇️
...or_v2/models/schemas/dynamic_services/scheduler.py 98.7% <95.6%> (-0.6%) ⬇️
...service_director_v2/api/routes/dynamic_services.py 89.4% <100.0%> (ø)
...src/simcore_service_director_v2/api/routes/meta.py 85.7% <100.0%> (ø)
...or-v2/src/simcore_service_director_v2/cli/_core.py 87.5% <100.0%> (+0.1%) ⬆️
...rc/simcore_service_director_v2/core/application.py 97.4% <100.0%> (ø)
... and 18 more

... and 715 files with indirect coverage changes

@GitHK GitHK marked this pull request as ready for review April 13, 2023 08:13
@GitHK GitHK requested a review from matusdrobuliak66 April 13, 2023 08:13
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Cool! thx

@GitHK GitHK enabled auto-merge (squash) April 18, 2023 07:24
@GitHK GitHK changed the title ♻️ director-v2 fixing mypy issues (first round) ♻️ director-v2 fixing mypy issues part 1/3 Apr 18, 2023
@codeclimate
Copy link

codeclimate bot commented Apr 18, 2023

Code Climate has analyzed commit 06dbb7e and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@GitHK GitHK merged commit c77379e into ITISFoundation:master Apr 18, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants