-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ director-v2
fixing mypy issues part 1/3
#4100
♻️ director-v2
fixing mypy issues part 1/3
#4100
Conversation
director-v2
fixing mypy issues (first round)
Codecov Report
@@ Coverage Diff @@
## master #4100 +/- ##
=========================================
- Coverage 85.4% 72.2% -13.3%
=========================================
Files 953 390 -563
Lines 41364 20261 -21103
Branches 957 174 -783
=========================================
- Hits 35345 14638 -20707
+ Misses 5801 5574 -227
+ Partials 218 49 -169
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Cool! thx
services/director-v2/src/simcore_service_director_v2/api/dependencies/rabbitmq.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/models/schemas/clusters.py
Show resolved
Hide resolved
…imcore-forked into pr-osparc-dy-sidecar-mypy
director-v2
fixing mypy issues (first round)director-v2
fixing mypy issues part 1/3
Code Climate has analyzed commit 06dbb7e and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Since there are lots of changes to be made in this service. Starting with a first round.
Related issue/s
How to test
DevOps Checklist