Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ fixes mypy issues in models-library #4533

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Jul 24, 2023

What do these changes do?

  • 🔨 adding mypy check for models-library in the CI
  • ♻️ fixes mypy issues in models-library

Related issue/s

How to test

cd packages/models-library
make install-dev
make mypy

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Jul 24, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Sundae milestone Jul 24, 2023
@matusdrobuliak66 matusdrobuliak66 added the t:maintenance Some planned maintenance work label Jul 24, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review July 24, 2023 07:20
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #4533 (af9910d) into master (5a7c6e5) will increase coverage by 0.5%.
The diff coverage is 86.5%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4533     +/-   ##
========================================
+ Coverage    86.6%   87.1%   +0.5%     
========================================
  Files        1009     844    -165     
  Lines       43182   38657   -4525     
  Branches      998     482    -516     
========================================
- Hits        37414   33708   -3706     
+ Misses       5538    4835    -703     
+ Partials      230     114    -116     
Flag Coverage Δ
integrationtests 68.3% <ø> (-0.1%) ⬇️
unittests 84.4% <86.5%> (+0.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...models_library/generated_models/docker_rest_api.py 100.0% <ø> (ø)
...odels-library/src/models_library/projects_nodes.py 91.8% <0.0%> (ø)
...tion_services_catalog/services/iter_sensitivity.py 48.1% <50.0%> (ø)
...s/models-library/src/models_library/utils/nodes.py 82.9% <57.1%> (ø)
...y/function_services_catalog/services/iter_range.py 81.2% <60.0%> (+4.7%) ⬆️
...models-library/src/models_library/aiodocker_api.py 74.0% <100.0%> (ø)
...els_library/api_schemas_long_running_tasks/base.py 66.6% <100.0%> (ø)
...-library/src/models_library/api_schemas_storage.py 89.9% <100.0%> (ø)
...ckages/models-library/src/models_library/docker.py 90.7% <100.0%> (ø)
...ages/models-library/src/models_library/generics.py 89.5% <100.0%> (ø)
... and 10 more

... and 169 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!
Please double check Config inheritance

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) July 25, 2023 06:49
@codeclimate
Copy link

codeclimate bot commented Jul 25, 2023

Code Climate has analyzed commit af9910d and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Security 1

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 we are officially mypyfied

@matusdrobuliak66 matusdrobuliak66 merged commit dbcc0f4 into ITISFoundation:master Jul 25, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix mypy issues in packages/models-library and activate in CI
3 participants