-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ fixes mypy issues in models-library
#4533
♻️ fixes mypy issues in models-library
#4533
Conversation
packages/models-library/src/models_library/utils/database_models_factory.py
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4533 +/- ##
========================================
+ Coverage 86.6% 87.1% +0.5%
========================================
Files 1009 844 -165
Lines 43182 38657 -4525
Branches 998 482 -516
========================================
- Hits 37414 33708 -3706
+ Misses 5538 4835 -703
+ Partials 230 114 -116
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
Please double check Config
inheritance
packages/models-library/src/models_library/api_schemas_storage.py
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
…uliak66/osparc-simcore into is4400/fix-mypy-models-library
Code Climate has analyzed commit af9910d and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 we are officially mypyfied
What do these changes do?
Related issue/s
packages/models-library
and activate in CI #4400How to test
cd packages/models-library make install-dev make mypy
DevOps Checklist