-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️🔨 catalog
: fixes mypy issues and add type-check step in CI
#4095
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4095 +/- ##
=========================================
+ Coverage 75.2% 85.4% +10.2%
=========================================
Files 916 791 -125
Lines 39541 36892 -2649
Branches 957 471 -486
=========================================
+ Hits 29752 31540 +1788
+ Misses 9570 5241 -4329
+ Partials 219 111 -108
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2156c7a
to
88492ea
Compare
Code Climate has analyzed commit 8ce1ca1 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Fixes mypy errors in
catalog
and addstype-check
step in CIRelated issue/s
How to test
cd services/catalog make install-dev make mypy
should not show any error