Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️🔨 catalog: fixes mypy issues and add type-check step in CI #4095

Merged
merged 5 commits into from
Apr 12, 2023

Conversation

pcrespov
Copy link
Member

What do these changes do?

Fixes mypy errors in catalog and adds type-check step in CI

Related issue/s

How to test

cd services/catalog
make install-dev
make mypy

should not show any error

@pcrespov pcrespov requested a review from sanderegg as a code owner April 11, 2023 20:43
@pcrespov pcrespov self-assigned this Apr 11, 2023
@pcrespov pcrespov added t:maintenance Some planned maintenance work a:catalog catalog service labels Apr 11, 2023
@pcrespov pcrespov added this to the Jelly Beans milestone Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #4095 (8ce1ca1) into master (fe0711a) will increase coverage by 10.2%.
The diff coverage is 88.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4095      +/-   ##
=========================================
+ Coverage    75.2%   85.4%   +10.2%     
=========================================
  Files         916     791     -125     
  Lines       39541   36892    -2649     
  Branches      957     471     -486     
=========================================
+ Hits        29752   31540    +1788     
+ Misses       9570    5241    -4329     
+ Partials      219     111     -108     
Flag Coverage Δ
integrationtests 52.3% <ø> (-14.3%) ⬇️
unittests 83.1% <88.8%> (+11.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../simcore_service_catalog/db/repositories/groups.py 60.5% <33.3%> (-1.7%) ⬇️
...e_service_catalog/api/routes/services_resources.py 90.9% <85.7%> (ø)
...rary/src/models_library/service_settings_labels.py 97.1% <100.0%> (ø)
...g/src/simcore_service_catalog/models/domain/dag.py 100.0% <100.0%> (ø)

... and 420 files with indirect coverage changes

@pcrespov pcrespov force-pushed the is4071/mypy-catalog branch from 2156c7a to 88492ea Compare April 12, 2023 09:05
@pcrespov pcrespov enabled auto-merge (squash) April 12, 2023 09:05
@codeclimate
Copy link

codeclimate bot commented Apr 12, 2023

Code Climate has analyzed commit 8ce1ca1 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit 3773ebb into ITISFoundation:master Apr 12, 2023
@pcrespov pcrespov deleted the is4071/mypy-catalog branch April 12, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:catalog catalog service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants