Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ webserver: fixes mypy issues in version_control plugin #4102

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Apr 13, 2023

What do these changes do?

  • fixes mypy issues in webserver's version_control plugin
  • moves plugin to folder version_control
    • shortens names of plugin modules
    • protected-prefix (_) for internal modules (i.e. cannot be imported outside the plugin)

Related issue/s

@pcrespov pcrespov self-assigned this Apr 13, 2023
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Apr 13, 2023
@pcrespov pcrespov added this to the Jelly Beans milestone Apr 13, 2023
@pcrespov pcrespov changed the title WIP ♻️ Is4071/mypy webserver version control WIP ♻️ webserver: fixes mypy issues in version_control plugin Apr 13, 2023
@pcrespov pcrespov force-pushed the is4071/mypy-webserver-version-control branch from ccc76af to c3704a5 Compare April 13, 2023 15:18
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #4102 (982e92d) into master (10d1ef7) will decrease coverage by 2.8%.
The diff coverage is 93.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4102      +/-   ##
=========================================
- Coverage    85.8%   83.0%    -2.8%     
=========================================
  Files         733     398     -335     
  Lines       33985   20616   -13369     
  Branches      843     174     -669     
=========================================
- Hits        29175   17121   -12054     
+ Misses       4610    3446    -1164     
+ Partials      200      49     -151     
Flag Coverage Δ
integrationtests 66.6% <77.1%> (-0.1%) ⬇️
unittests 84.0% <93.8%> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...imcore_service_webserver/version_control/errors.py 100.0% <ø> (ø)
...rc/simcore_service_webserver/version_control/db.py 91.9% <78.9%> (ø)
...re_service_webserver/version_control/vc_changes.py 72.7% <80.0%> (ø)
...core_service_webserver/meta_modeling_iterations.py 87.7% <90.0%> (ø)
...server/src/simcore_service_webserver/_constants.py 100.0% <100.0%> (ø)
...erver/src/simcore_service_webserver/application.py 97.8% <100.0%> (ø)
.../simcore_service_webserver/director_v2_handlers.py 92.7% <100.0%> (ø)
...e_service_webserver/login/handlers_confirmation.py 90.6% <100.0%> (-0.1%) ⬇️
...src/simcore_service_webserver/login/utils_email.py 93.3% <100.0%> (ø)
...imcore_service_webserver/meta_modeling_handlers.py 84.2% <100.0%> (ø)
... and 9 more

... and 423 files with indirect coverage changes

@pcrespov pcrespov marked this pull request as ready for review April 13, 2023 16:29
@pcrespov pcrespov changed the title WIP ♻️ webserver: fixes mypy issues in version_control plugin ♻️ webserver: fixes mypy issues in version_control plugin Apr 13, 2023
@codeclimate
Copy link

codeclimate bot commented Apr 13, 2023

Code Climate has analyzed commit 982e92d and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov enabled auto-merge (squash) April 13, 2023 19:18
@pcrespov pcrespov merged commit ae41466 into ITISFoundation:master Apr 14, 2023
@pcrespov pcrespov deleted the is4071/mypy-webserver-version-control branch April 14, 2023 08:06
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants