♻️ webserver: fixes mypy issues in statics plugin

[pcrespov]

What do these changes do?

• ♻️ refactors statics plugin in webserver:
  • plugin under statics folder
  • protected internal modules
  • general code cleanup (e.g. _logger, TODO, ...)

Related issue/s

• Implements part of Maintenance: make mypy pass in all services/packages in repo #4071

How to test

cd services/web/server
make mypy | grep statics

[codecov]

Codecov Report

Merging #4190 (05b5670) into master (902f3d1) will decrease coverage by 1.6%.
The diff coverage is 83.8%.

@@            Coverage Diff            @@
##           master   #4190      +/-   ##
=========================================
- Coverage    79.5%   77.9%    -1.6%     
=========================================
  Files         932     399     -533     
  Lines       40988   20700   -20288     
  Branches      955     173     -782     
=========================================
- Hits        32609   16143   -16466     
+ Misses       8175    4508    -3667     
+ Partials      204      49     -155     

Flag	Coverage Δ
integrationtests	62.2% <83.8%> (+0.8%)	⬆️
unittests	83.9% <83.8%> (+2.4%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rc/simcore_service_webserver/statics/_constants.py	100.0% <ø> (ø)
...r/src/simcore_service_webserver/statics/_events.py	38.1% <50.0%> (ø)
...erver/src/simcore_service_webserver/application.py	97.8% <100.0%> (ø)
.../simcore_service_webserver/application_settings.py	98.7% <100.0%> (ø)
.../src/simcore_service_webserver/products/_events.py	95.4% <100.0%> (ø)
...r/src/simcore_service_webserver/products/_model.py	96.5% <100.0%> (ø)
...src/simcore_service_webserver/statics/_handlers.py	43.7% <100.0%> (ø)
...er/src/simcore_service_webserver/statics/plugin.py	61.1% <100.0%> (ø)
.../src/simcore_service_webserver/statics/settings.py	83.3% <100.0%> (ø)

... and 551 files with indirect coverage changes

[matusdrobuliak66]

👍

[codeclimate]

Code Climate has analyzed commit 05b5670 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication