♻️ webserver: fixes mypy issues in diagnostics plugin

[pcrespov]

What do these changes do?

• ♻️ refactors diagnostics plugin in webserver:
  • plugin under diagnostics folder
  • protected internal modules
  • general code cleanup (e.g. _logger, TODO, ...)
  • Removed unused "STATIC_WEBSERVER_ENABLED", "WEBSERVER_STATIC_MODULE_ENABLED"

Related issue/s

• Implements part of Maintenance: make mypy pass in all services/packages in repo #4071

How to test

cd services/web/server
make mypy | grep diagnostics

[codecov]

Codecov Report

Merging #4187 (9a659a0) into master (290f0f7) will decrease coverage by 2.3%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4187      +/-   ##
=========================================
- Coverage    82.0%   79.8%    -2.3%     
=========================================
  Files         958       8     -950     
  Lines       41532     382   -41150     
  Branches      955       0     -955     
=========================================
- Hits        34078     305   -33773     
+ Misses       7250      77    -7173     
+ Partials      204       0     -204     

Flag	Coverage Δ
integrationtests	79.8% <ø> (+20.6%)	⬆️
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 952 files with indirect coverage changes

[codeclimate]

Code Climate has analyzed commit 9a659a0 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication