Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ webserver: fixes mypy issues in studies_dispatcher plugin #4188

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented May 3, 2023

What do these changes do?

  • ♻️ refactors studies_dispatcher plugin in webserver

Related issue/s

How to test

cd services/web/server
make mypy | grep studies_dispatcher

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this May 3, 2023
@matusdrobuliak66 matusdrobuliak66 added the t:maintenance Some planned maintenance work label May 3, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the The Next Milestone milestone May 3, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review May 3, 2023 05:53
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #4188 (5c43fed) into master (7a7c601) will increase coverage by 1.3%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4188      +/-   ##
=========================================
+ Coverage    81.6%   82.9%    +1.3%     
=========================================
  Files         828     399     -429     
  Lines       36995   20715   -16280     
  Branches      877     173     -704     
=========================================
- Hits        30204   17192   -13012     
+ Misses       6590    3474    -3116     
+ Partials      201      49     -152     
Flag Coverage Δ
integrationtests 67.2% <23.5%> (+4.9%) ⬆️
unittests 84.0% <100.0%> (+5.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._service_webserver/studies_dispatcher/_projects.py 93.8% <ø> (ø)
...e_service_webserver/studies_dispatcher/settings.py 100.0% <ø> (ø)
...core_service_webserver/studies_dispatcher/_core.py 77.7% <100.0%> (ø)
...re_service_webserver/studies_dispatcher/_models.py 97.1% <100.0%> (ø)
...ebserver/studies_dispatcher/_redirects_handlers.py 85.7% <100.0%> (ø)
...ice_webserver/studies_dispatcher/_rest_handlers.py 91.7% <100.0%> (+0.2%) ⬆️
...ce_webserver/studies_dispatcher/_studies_access.py 90.7% <100.0%> (ø)

... and 574 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the _models.py and correct it before merging. Thanks a lot!

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) May 4, 2023 17:30
@codeclimate
Copy link

codeclimate bot commented May 4, 2023

Code Climate has analyzed commit 5c43fed and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@matusdrobuliak66 matusdrobuliak66 merged commit beedbd4 into ITISFoundation:master May 4, 2023
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants