Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ webserver: fixes mypy issues in rest plugin #4334

Merged
merged 11 commits into from
Jun 8, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 8, 2023

What do these changes do?

  • ♻️ fixes mypy issues in webserver plugin rest
  • ♻️ moves plugin to rest folder
  • ♻️ protected names for internal modules

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv tests/**/test_*rest*.py
make mypy | grep rest

@pcrespov pcrespov self-assigned this Jun 8, 2023
@pcrespov pcrespov added a:webserver issue related to the webserver service t:maintenance Some planned maintenance work labels Jun 8, 2023
@pcrespov pcrespov added this to the Watermelon milestone Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #4334 (da8b76e) into master (36f9f79) will decrease coverage by 5.1%.
The diff coverage is 95.7%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4334     +/-   ##
========================================
- Coverage    83.2%   78.1%   -5.1%     
========================================
  Files         868     776     -92     
  Lines       35957   35549    -408     
  Branches      983     460    -523     
========================================
- Hits        29929   27783   -2146     
- Misses       5818    7668   +1850     
+ Partials      210      98    -112     
Flag Coverage Δ
integrationtests ?
unittests 78.1% <95.7%> (-4.6%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/simcore_service_webserver/rest/healthcheck.py 74.1% <85.7%> (ø)
...er/src/simcore_service_webserver/rest/_handlers.py 58.1% <88.8%> (ø)
...ls-library/src/models_library/utils/change_case.py 100.0% <100.0%> (ø)
...erver/src/simcore_service_webserver/application.py 97.9% <100.0%> (ø)
.../simcore_service_webserver/application_settings.py 79.7% <100.0%> (-18.5%) ⬇️
...core_service_webserver/diagnostics/_healthcheck.py 43.7% <100.0%> (-53.2%) ⬇️
...rc/simcore_service_webserver/diagnostics/plugin.py 55.5% <100.0%> (-44.5%) ⬇️
...rc/simcore_service_webserver/director_v2/plugin.py 95.8% <100.0%> (ø)
...rver/src/simcore_service_webserver/login/plugin.py 90.0% <100.0%> (ø)
...ore_service_webserver/projects/_crud_read_utils.py 73.1% <100.0%> (-24.4%) ⬇️
... and 6 more

... and 435 files with indirect coverage changes

@pcrespov pcrespov marked this pull request as ready for review June 8, 2023 09:22
@pcrespov pcrespov force-pushed the is7071/mypy-webserver-rest branch from 1571425 to da8b76e Compare June 8, 2023 17:17
@pcrespov pcrespov enabled auto-merge (squash) June 8, 2023 17:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jun 8, 2023

Code Climate has analyzed commit da8b76e and detected 0 issues on this pull request.

View more on Code Climate.

@pcrespov pcrespov merged commit 13e95f6 into ITISFoundation:master Jun 8, 2023
@pcrespov pcrespov deleted the is7071/mypy-webserver-rest branch June 8, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants