Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ webserver: fixes mypy issues in storage plugin #4199

Conversation

matusdrobuliak66
Copy link
Contributor

What do these changes do?

  • ♻️ refactors storage plugin in webserver:

Related issue/s

How to test

cd services/web/server
make mypy | grep storage

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this May 7, 2023
@matusdrobuliak66 matusdrobuliak66 added the t:maintenance Some planned maintenance work label May 7, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Pastel de Nata milestone May 7, 2023
@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #4199 (37b4ec4) into master (1a952c0) will decrease coverage by 6.6%.
The diff coverage is 90.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4199      +/-   ##
=========================================
- Coverage    85.5%   78.9%    -6.6%     
=========================================
  Files         954     396     -558     
  Lines       41405   20567   -20838     
  Branches      953     173     -780     
=========================================
- Hits        35439   16247   -19192     
+ Misses       5749    4271    -1478     
+ Partials      217      49     -168     
Flag Coverage Δ
integrationtests 61.9% <38.4%> (-6.7%) ⬇️
unittests 84.0% <90.3%> (+1.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/simcore_service_webserver/storage/_handlers.py 71.0% <37.5%> (ø)
...erver/src/simcore_service_webserver/application.py 97.8% <100.0%> (ø)
.../simcore_service_webserver/application_settings.py 98.7% <100.0%> (ø)
...simcore_service_webserver/diagnostics/_handlers.py 49.1% <100.0%> (+0.8%) ⬆️
...ver/src/simcore_service_webserver/login/storage.py 94.5% <100.0%> (+<0.1%) ⬆️
...imcore_service_webserver/projects/_create_utils.py 96.8% <100.0%> (ø)
...imcore_service_webserver/projects/_delete_utils.py 78.1% <100.0%> (ø)
...simcore_service_webserver/projects/projects_api.py 81.9% <100.0%> (-11.7%) ⬇️
...r/src/simcore_service_webserver/storage/_routes.py 100.0% <100.0%> (ø)
...erver/src/simcore_service_webserver/storage/api.py 46.9% <100.0%> (ø)
... and 4 more

... and 657 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review May 9, 2023 07:12
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) May 9, 2023 08:44
@codeclimate
Copy link

codeclimate bot commented May 11, 2023

Code Climate has analyzed commit 37b4ec4 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@matusdrobuliak66 matusdrobuliak66 merged commit 9781503 into ITISFoundation:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants