Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ webserver: fixes mypy issues in security plugin #4183

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented May 2, 2023

What do these changes do?

  • ♻️ refactors security plugin in webserver:
    • plugin under security folder
    • protected internal modules
    • removed attr by dataclass
    • general code cleanup

Related issue/s

How to test

cd services/web/server
make mypy | grep security

@pcrespov pcrespov self-assigned this May 2, 2023
@pcrespov pcrespov added a:webserver issue related to the webserver service t:maintenance Some planned maintenance work labels May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #4183 (18d57dd) into master (6162274) will decrease coverage by 1.0%.
The diff coverage is 91.4%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4183     +/-   ##
========================================
- Coverage    85.5%   84.6%   -1.0%     
========================================
  Files         958     958             
  Lines       41545   41558     +13     
  Branches      955     955             
========================================
- Hits        35539   35173    -366     
- Misses       5789    6168    +379     
  Partials      217     217             
Flag Coverage Δ
integrationtests 64.3% <82.1%> (-3.1%) ⬇️
unittests 82.4% <90.6%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...simcore_service_webserver/diagnostics/_handlers.py 47.4% <28.5%> (+<0.1%) ⬆️
...imcore_service_webserver/security/_access_model.py 86.0% <85.1%> (ø)
...mcore_service_webserver/security/_authorization.py 94.8% <92.5%> (ø)
...erver/src/simcore_service_webserver/application.py 97.8% <100.0%> (ø)
.../src/simcore_service_webserver/catalog_handlers.py 43.3% <100.0%> (ø)
...ervice_webserver/catalog_handlers_reverse_proxy.py 96.2% <100.0%> (ø)
...src/simcore_service_webserver/clusters/handlers.py 100.0% <100.0%> (ø)
.../simcore_service_webserver/director_v2_handlers.py 92.8% <100.0%> (ø)
...er/src/simcore_service_webserver/email_handlers.py 91.4% <100.0%> (ø)
...ore_service_webserver/exporter/request_handlers.py 96.0% <100.0%> (ø)
... and 28 more

... and 27 files with indirect coverage changes

@pcrespov pcrespov force-pushed the mypy/webserver-security-plugin branch from 5b41f52 to c9b60c0 Compare May 2, 2023 16:19
@pcrespov pcrespov added this to the The Next Milestone milestone May 2, 2023
@pcrespov pcrespov marked this pull request as ready for review May 2, 2023 16:55
@pcrespov pcrespov requested review from sanderegg and GitHK as code owners May 2, 2023 16:55
@pcrespov pcrespov requested a review from matusdrobuliak66 May 2, 2023 16:55
@pcrespov pcrespov changed the title ♻️ Mypy/webserver security plugin ♻️ mypy webserver security plugin May 2, 2023
@matusdrobuliak66 matusdrobuliak66 changed the title ♻️ mypy webserver security plugin ♻️ webserver: fixes mypy issues in security plugin May 2, 2023
@pcrespov pcrespov enabled auto-merge (squash) May 3, 2023 14:59
@pcrespov pcrespov force-pushed the mypy/webserver-security-plugin branch from e6aa59d to 7724305 Compare May 4, 2023 08:20
@codeclimate
Copy link

codeclimate bot commented May 4, 2023

Code Climate has analyzed commit 18d57dd and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit 0b69cfb into ITISFoundation:master May 4, 2023
@pcrespov pcrespov deleted the mypy/webserver-security-plugin branch May 5, 2023 09:31
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants