Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ webserver: fixes mypy issues in redis & products_middlewares plugins #4131

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Apr 17, 2023

What do these changes do?

  • fixes mypy issues in webserver's redis & products_middlewares plugin

Related issue/s

How to test

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review April 17, 2023 17:57
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) April 17, 2023 18:11
@matusdrobuliak66 matusdrobuliak66 self-assigned this Apr 17, 2023
@matusdrobuliak66 matusdrobuliak66 added the t:maintenance Some planned maintenance work label Apr 17, 2023
@matusdrobuliak66 matusdrobuliak66 added this to the Jelly Beans milestone Apr 17, 2023
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

services/web/server/src/simcore_service_webserver/redis.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #4131 (ec9aa06) into master (60737a2) will decrease coverage by 4.6%.
The diff coverage is 93.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4131      +/-   ##
=========================================
- Coverage    85.9%   81.4%    -4.6%     
=========================================
  Files         908     398     -510     
  Lines       40521   20646   -19875     
  Branches      879     174     -705     
=========================================
- Hits        34821   16806   -18015     
+ Misses       5498    3791    -1707     
+ Partials      202      49     -153     
Flag Coverage Δ
integrationtests 66.6% <80.0%> (-0.1%) ⬇️
unittests 80.9% <93.3%> (-1.8%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../web/server/src/simcore_service_webserver/redis.py 93.1% <80.0%> (-1.8%) ⬇️
.../simcore_service_webserver/products_middlewares.py 100.0% <100.0%> (ø)

... and 614 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) April 18, 2023 13:51
@codeclimate
Copy link

codeclimate bot commented Apr 18, 2023

Code Climate has analyzed commit ec9aa06 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants