Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Maintenance: enable mypy in storage #4086

Merged
merged 17 commits into from
Apr 13, 2023

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Apr 11, 2023

What do these changes do?

Related issue/s

relates to #4071

How to test

cd services/storage
make install-dev
make mypy

@sanderegg sanderegg added the a:storage issue related to storage service label Apr 11, 2023
@sanderegg sanderegg added this to the Jelly Beans milestone Apr 11, 2023
@sanderegg sanderegg requested a review from pcrespov as a code owner April 11, 2023 11:12
@sanderegg sanderegg self-assigned this Apr 11, 2023
@sanderegg sanderegg marked this pull request as draft April 11, 2023 11:13
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #4086 (b818ae3) into master (c6f9674) will decrease coverage by 17.0%.
The diff coverage is 95.6%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4086      +/-   ##
=========================================
- Coverage    85.4%   68.5%   -17.0%     
=========================================
  Files         952     434     -518     
  Lines       41308   22362   -18946     
  Branches      957     174     -783     
=========================================
- Hits        35312   15336   -19976     
- Misses       5777    6977    +1200     
+ Partials      219      49     -170     
Flag Coverage Δ
integrationtests 66.7% <ø> (+<0.1%) ⬆️
unittests 90.4% <95.6%> (+8.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...vices/storage/src/simcore_service_storage/_meta.py 100.0% <ø> (ø)
...service_storage/datcore_adapter/datcore_adapter.py 34.9% <28.5%> (-0.1%) ⬇️
...torage/datcore_adapter/datcore_adapter_settings.py 100.0% <100.0%> (ø)
services/storage/src/simcore_service_storage/db.py 89.5% <100.0%> (ø)
...e/src/simcore_service_storage/db_file_meta_data.py 98.1% <100.0%> (ø)
...storage/src/simcore_service_storage/db_projects.py 100.0% <100.0%> (ø)
...e/src/simcore_service_storage/handlers_datasets.py 100.0% <100.0%> (ø)
...rage/src/simcore_service_storage/handlers_files.py 99.1% <100.0%> (+<0.1%) ⬆️
...age/src/simcore_service_storage/handlers_health.py 100.0% <100.0%> (ø)
.../src/simcore_service_storage/handlers_locations.py 96.0% <100.0%> (ø)
... and 6 more

... and 743 files with indirect coverage changes

@sanderegg sanderegg marked this pull request as ready for review April 11, 2023 13:54
@sanderegg sanderegg force-pushed the maintenance/mypy branch 2 times, most recently from 8d8f366 to 3f170d7 Compare April 12, 2023 21:04
@codeclimate
Copy link

codeclimate bot commented Apr 13, 2023

Code Climate has analyzed commit b818ae3 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg enabled auto-merge (squash) April 13, 2023 06:19
@sanderegg sanderegg merged commit c1846f6 into ITISFoundation:master Apr 13, 2023
@sanderegg sanderegg deleted the maintenance/mypy branch April 13, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:storage issue related to storage service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants