Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Removing unused code #4215

Merged
merged 2 commits into from
May 10, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented May 10, 2023

What do these changes do?

  • ⚰️ This code which was supposed to be used by a rewrite of the internals of the dynamic-sidecar-schduler from the director-v2. It now got outdated since different design decisions will be taken briefly which do not require this any more.
  • 🚫 Also blocks enabling mypy in director-v2 since: ✨ enables mypy for director-v2 in CI #4217

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK self-assigned this May 10, 2023
@GitHK GitHK added the a:director-v2 issue related with the director-v2 service label May 10, 2023
@GitHK GitHK added this to the Pastel de Nata milestone May 10, 2023
@GitHK GitHK added the t:maintenance Some planned maintenance work label May 10, 2023
@GitHK GitHK marked this pull request as ready for review May 10, 2023 12:09
@GitHK GitHK requested review from sanderegg and pcrespov as code owners May 10, 2023 12:09
@GitHK GitHK requested a review from matusdrobuliak66 May 10, 2023 12:09
@codeclimate
Copy link

codeclimate bot commented May 10, 2023

Code Climate has analyzed commit 8c611eb and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #4215 (8c611eb) into master (1745b1d) will decrease coverage by 31.8%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4215      +/-   ##
=========================================
- Coverage    82.5%   50.7%   -31.8%     
=========================================
  Files         964     365     -599     
  Lines       41705   18917   -22788     
  Branches      953       0     -953     
=========================================
- Hits        34407    9593   -24814     
- Misses       7094    9324    +2230     
+ Partials      204       0     -204     
Flag Coverage Δ
integrationtests 50.7% <ø> (?)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 850 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is a lot of code! :-)

@GitHK GitHK enabled auto-merge (squash) May 10, 2023 13:49
@GitHK GitHK merged commit d294af6 into ITISFoundation:master May 10, 2023
@GitHK GitHK deleted the pr-osparc-remove-unused-code branch May 10, 2023 14:01
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

director-v2 mypy Part 4 followup
3 participants