♻️ webserver: fixes mypy issues in director_v2 plugin

[matusdrobuliak66]

What do these changes do?

• ♻️ refactors director_v2 plugin in webserver:

Related issue/s

• Maintenance: make mypy pass in all services/packages in repo #4071
• https://git.speag.com/oSparc/osparc-ops-environments/-/issues/570

How to test

cd services/web/server
make mypy | grep director_v2

DevOps Checklist

• Check with Andrei commented test
• Check code smells

[codecov]

Codecov Report

Merging #4186 (ef3458c) into master (fe4dee6) will decrease coverage by 1.7%.
The diff coverage is 93.6%.

@@            Coverage Diff            @@
##           master   #4186      +/-   ##
=========================================
- Coverage    84.7%   83.0%    -1.7%     
=========================================
  Files         959     400     -559     
  Lines       41600   20738   -20862     
  Branches      955     173     -782     
=========================================
- Hits        35236   17215   -18021     
+ Misses       6147    3474    -2673     
+ Partials      217      49     -168     

Flag	Coverage Δ
integrationtests	67.2% <88.8%> (-0.1%)	⬇️
unittests	84.0% <93.6%> (+2.5%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...imcore_service_webserver/director_v2/exceptions.py	100.0% <ø> (ø)
...imcore_service_webserver/garbage_collector_core.py	83.7% <71.4%> (+0.6%)	⬆️
...ervice_webserver/director_v2/_core_computations.py	93.7% <73.3%> (ø)
...vice_webserver/projects/projects_nodes_handlers.py	80.2% <80.0%> (+40.1%)	⬆️
...ce_webserver/director_v2/_core_dynamic_services.py	70.4% <94.4%> (ø)
...erver/src/simcore_service_webserver/application.py	97.8% <100.0%> (ø)
.../simcore_service_webserver/application_settings.py	98.7% <100.0%> (+0.6%)	⬆️
...src/simcore_service_webserver/clusters/handlers.py	100.0% <100.0%> (ø)
...r/src/simcore_service_webserver/clusters/plugin.py	100.0% <100.0%> (ø)
...simcore_service_webserver/diagnostics/_handlers.py	48.3% <100.0%> (+0.8%)	⬆️
... and 18 more

... and 656 files with indirect coverage changes

[pcrespov]

Fix code smells detected by sonarcloud please :-). (check with me if you have any questions)

[GitHK]

Please check my comments

[sanderegg]

Thanks! please check the comments.

[sanderegg]

Thanks! please check the comments.

[matusdrobuliak66]

Fix code smells detected by sonarcloud please :-). (check with me if you have any questions)

Yes, I would be glad to have a short discussion about some of the code smells.

[codeclimate]

Code Climate has analyzed commit ef3458c and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
2.2% Duplication