[DO-NOT-MERGE] Binarysearch/17 #2246
Conversation
This reverts commit 7821619.
This reverts commit 623c302.
This reverts commit dd952e6.
This reverts commit dcf2064.
This reverts commit 3dc099a.
This reverts commit 193178e.
This reverts commit dfc9c2f.
This reverts commit c5cbfc9.
This reverts commit cadd72e.
This reverts commit 2d71cce.
This reverts commit e59ded2.
This reverts commit 41cc83b.
This reverts commit ca118d3.
This reverts commit d26b317.
This reverts commit 8197ffe.
This reverts commit 72a8582.
This reverts commit a7a746f.
This reverts commit ef0739c.
This reverts commit 3af9773.
This reverts commit 9f27ff2.
This reverts commit 366cd02.
This reverts commit 001f741.
This reverts commit 594b23b.
This reverts commit a95676a.
|
[CHATOPS:HELP] ChatOps commands.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
LanguageTool
docs/api/remove.md|178 col 59| “Google” is a proper noun and needs to be capitalized. (A_GOOGLE[1])
Suggestions: Google
Rule: https://community.languagetool.org/rule/show/A_GOOGLE?lang=en-US&subId=1
Category: GRAMMAR
docs/api/remove.md|254 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/remove.md|254 col 22| If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
docs/api/remove.md|254 col 50| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/remove.md|268 col 7| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|86 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/search.md|134 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|190 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|238 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|295 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/search.md|344 col 59| “Google” is a proper noun and needs to be capitalized. (A_GOOGLE[1])
Suggestions: Google
Rule: https://community.languagetool.org/rule/show/A_GOOGLE?lang=en-US&subId=1
Category: GRAMMAR
docs/api/search.md|357 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|414 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|463 col 59| “Google” is a proper noun and needs to be capitalized. (A_GOOGLE[1])
Suggestions: Google
Rule: https://community.languagetool.org/rule/show/A_GOOGLE?lang=en-US&subId=1
Category: GRAMMAR
docs/api/search.md|476 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|546 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/search.md|604 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|675 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|733 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|786 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/search.md|832 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|887 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|933 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|988 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/search.md|1035 col 59| “Google” is a proper noun and needs to be capitalized. (A_GOOGLE[1])
Suggestions: Google
Rule: https://community.languagetool.org/rule/show/A_GOOGLE?lang=en-US&subId=1
Category: GRAMMAR
docs/api/search.md|1048 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|1103 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|1150 col 59| “Google” is a proper noun and needs to be capitalized. (A_GOOGLE[1])
Suggestions: Google
Rule: https://community.languagetool.org/rule/show/A_GOOGLE?lang=en-US&subId=1
Category: GRAMMAR
docs/api/search.md|1163 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|1231 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/search.md|1287 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|1356 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/search.md|1412 col 9| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/update.md|67 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/update.md|68 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/update.md|156 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/update.md|157 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/update.md|185 col 59| “Google” is a proper noun and needs to be capitalized. (A_GOOGLE[1])
Suggestions: Google
Rule: https://community.languagetool.org/rule/show/A_GOOGLE?lang=en-US&subId=1
Category: GRAMMAR
docs/api/update.md|278 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/update.md|279 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/upsert.md|71 col 8| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/upsert.md|72 col 77| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/upsert.md|159 col 6| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/upsert.md|160 col 75| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/api/upsert.md|188 col 57| “Google” is a proper noun and needs to be capitalized. (A_GOOGLE[1])
Suggestions: Google
Rule: https://community.languagetool.org/rule/show/A_GOOGLE?lang=en-US&subId=1
Category: GRAMMAR
docs/api/upsert.md|280 col 6| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/api/upsert.md|281 col 75| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/tutorial/get-started.md|326 col 8| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Conn
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/tutorial/vald-agent-standalone-on-k8s.md|239 col 8| This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Conn
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
docs/tutorial/vald-agent-standalone-on-k8s.md|340 col 31| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
docs/tutorial/vald-agent-standalone-on-k8s.md|343 col 32| This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: IDs
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| // } | ||
| func Test_unimplementedTest(t *testing.T) { | ||
| // this unit test function is not implemented yet | ||
| } |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Func
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
| | :----: | :----- | :--------------------- | :------: | :------------------------------------------------------------- | | ||
| | id | string | | \* | The ID of a vector. ID should consist of 1 or more characters. | | ||
| | vector | float | repeated(Array[float]) | \* | The vector data. Its dimension is between 2 and 65,536. | | ||
| | id | string | | \* | the ID of a vector. ID should consist of 1 or more characters. | |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| | id | string | | \* | The ID of a vector. ID should consist of 1 or more characters. | | ||
| | vector | float | repeated(Array[float]) | \* | The vector data. Its dimension is between 2 and 65,536. | | ||
| | id | string | | \* | the ID of a vector. ID should consist of 1 or more characters. | | ||
| | vector | float | repeated(Array[float]) | \* | the vector data. its dimension is between 2 and 65,536. | |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
| | :----: | :----- | :--------------------- | :------: | :--------------------------------------------------------------- | | ||
| | id | string | | \* | The ID of the vector. ID should consist of 1 or more characters. | | ||
| | vector | float | repeated(Array[float]) | \* | The vector data. Its dimension is between 2 and 65,536. | | ||
| | id | string | | \* | the ID of the vector. ID should consist of 1 or more characters. | |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| | id | string | | \* | The ID of the vector. ID should consist of 1 or more characters. | | ||
| | vector | float | repeated(Array[float]) | \* | The vector data. Its dimension is between 2 and 65,536. | | ||
| | id | string | | \* | the ID of the vector. ID should consist of 1 or more characters. | | ||
| | vector | float | repeated(Array[float]) | \* | the vector data. its dimension is between 2 and 65,536. | |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This sentence does not start with an uppercase letter. (UPPERCASE_SENTENCE_START)
Suggestions: Its
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/UPPERCASE_SENTENCE_START?lang=en-US
Category: CASING
| | :---: | :----- | :---- | :------: | :------------------------------------------------------------- | | ||
| | id | string | | \* | The ID of a vector. ID should consist of 1 or more characters. | | ||
| | id | string | | \* | the ID of a vector. ID should consist of 1 or more characters. | |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| | config | Config | | \* | The configuration of the insert request. | | ||
| | field | type | label | required | desc. | | ||
| | :----: | :-------- | :---- | :------: | :-------------------------------------- | | ||
| | id | Object.ID | | \* | the id of vector | |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| | config | Config | | \* | The configuration of the insert request. | | ||
| | field | type | label | required | desc. | | ||
| | :----: | :-------- | :---- | :------: | :-------------------------------------- | | ||
| | id | Object.ID | | \* | the id of vector | |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
| | config | Config | | \* | The configuration of the insert request. | | ||
| | field | type | label | required | desc. | | ||
| | :----: | :-------- | :---- | :------: | :-------------------------------------- | | ||
| | id | Object.ID | | \* | the id of vector | |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| | :---: | :----- | :---- | :------: | :------------------------------------------------------------- | | ||
| | id | string | | \* | The ID of a vector. ID should consist of 1 or more characters. | | ||
| | id | string | | \* | the ID of a vector. ID should consist of 1 or more characters. | |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2246 +/- ##
==========================================
- Coverage 30.50% 29.98% -0.53%
==========================================
Files 362 369 +7
Lines 35376 35086 -290
==========================================
- Hits 10792 10520 -272
- Misses 24073 24085 +12
+ Partials 511 481 -30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
golangci
internal/test/data/vector/gen_test.go|735| internal/test/data/vector/gen_test.go:735: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/test/data/vector/gen_test.go|755| internal/test/data/vector/gen_test.go:755: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/test/data/vector/gen_test.go|825| internal/test/data/vector/gen_test.go:825: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/test/data/vector/gen_test.go|844| internal/test/data/vector/gen_test.go:844: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/test/data/vector/gen_test.go|913| internal/test/data/vector/gen_test.go:913: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/test/data/vector/gen_test.go|932| internal/test/data/vector/gen_test.go:932: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/test/data/vector/gen_test.go|1001| internal/test/data/vector/gen_test.go:1001: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/test/data/vector/gen_test.go|1020| internal/test/data/vector/gen_test.go:1020: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/test/data/vector/gen_test.go|1090| internal/test/data/vector/gen_test.go:1090: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/test/data/vector/gen_test.go|1110| internal/test/data/vector/gen_test.go:1110: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/test/data/vector/gen_test.go|1180| internal/test/data/vector/gen_test.go:1180: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/test/data/vector/gen_test.go|1199| internal/test/data/vector/gen_test.go:1199: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/test/data/vector/gen_test.go|1268| internal/test/data/vector/gen_test.go:1268: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/test/data/vector/gen_test.go|1287| internal/test/data/vector/gen_test.go:1287: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/errors/blob_test.go|607| internal/errors/blob_test.go:607: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/errors/blob_test.go|625| internal/errors/blob_test.go:625: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/errors/blob_test.go|695| internal/errors/blob_test.go:695: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/errors/blob_test.go|713| internal/errors/blob_test.go:713: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/errors/circuitbreaker_test.go|47| internal/errors/circuitbreaker_test.go:47: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/errors/circuitbreaker_test.go|65| internal/errors/circuitbreaker_test.go:65: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/errors/circuitbreaker_test.go|132| internal/errors/circuitbreaker_test.go:132: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
internal/errors/circuitbreaker_test.go|150| internal/errors/circuitbreaker_test.go:150: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
pkg/agent/core/ngt/service/vqueue/indexmap.go|35 col 24| G103: Use of unsafe calls should be audited (gosec)
internal/singleflight/singleflight.go|27 col 2| wg is unused (structcheck)
internal/singleflight/singleflight.go|28 col 2| val is unused (structcheck)
internal/singleflight/singleflight.go|29 col 2| err is unused (structcheck)
internal/singleflight/singleflight.go|30 col 2| dups is unused (structcheck)
internal/singleflight/singleflight.go|39 col 2| m is unused (structcheck)
internal/singleflight/singleflight_test.go|85 col 3| ctx is unused (structcheck)
internal/singleflight/singleflight_test.go|86 col 3| key is unused (structcheck)
internal/singleflight/singleflight_test.go|87 col 3| fn is unused (structcheck)
internal/singleflight/singleflight_test.go|90 col 3| wantV is unused (structcheck)
internal/singleflight/singleflight_test.go|91 col 3| wantShared is unused (structcheck)
internal/singleflight/singleflight_test.go|92 col 3| err is unused (structcheck)
internal/singleflight/singleflight_test.go|96 col 3| args is unused (structcheck)
internal/singleflight/singleflight_test.go|97 col 3| want is unused (structcheck)
internal/singleflight/singleflight_test.go|98 col 3| beforeFunc is unused (structcheck)
internal/singleflight/singleflight_test.go|99 col 3| execFunc is unused (structcheck)
internal/singleflight/singleflight_test.go|100 col 3| checkFunc is unused (structcheck)
internal/singleflight/singleflight_test.go|101 col 3| afterFunc is unused (structcheck)
internal/singleflight/singleflight_test.go|95 col 3| name is unused (structcheck)
internal/io/io_test.go|885 col 3| e is unused (structcheck)
internal/observability/metrics/grpc/grpc_test.go|109 col 3| g is unused (structcheck)
internal/observability/metrics/grpc/grpc_test.go|193 col 3| g is unused (structcheck)
internal/observability/metrics/mem/index/index_test.go|109 col 3| m is unused (structcheck)
internal/observability/metrics/mem/index/index_test.go|193 col 3| m is unused (structcheck)
internal/observability/metrics/runtime/cgo/cgo_test.go|109 col 3| c is unused (structcheck)
internal/observability/metrics/runtime/cgo/cgo_test.go|193 col 3| c is unused (structcheck)
internal/observability/metrics/runtime/goroutine/goroutine_test.go|109 col 3| g is unused (structcheck)
internal/db/storage/blob/s3/reader/io/io_test.go|115 col 3| c is unused (structcheck)
internal/observability/trace/trace_test.go|226 col 3| tr is unused (structcheck)
internal/backoff/backoff_test.go|607 col 3| found a struct that contains a context.Context field (containedctx)
internal/backoff/context_test.go|29 col 3| found a struct that contains a context.Context field (containedctx)
cmd/agent/core/ngt/main_test.go|23 col 2| import 'github.com/vdaas/vald/internal/test/goleak' is not allowed from list 'Main' (depguard)
cmd/agent/sidecar/main_test.go|23 col 2| import 'github.com/vdaas/vald/internal/test/goleak' is not allowed from list 'Main' (depguard)
cmd/discoverer/k8s/main_test.go|23 col 2| import 'github.com/vdaas/vald/internal/test/goleak' is not allowed from list 'Main' (depguard)
internal/cache/option_test.go|61 col 13| cache.cache is missing fields cacher, expireDur, expireCheckDur (exhaustruct)
internal/cache/option_test.go|74 col 13| cache.cache is missing fields cacher, expireDur, expireCheckDur, expiredHook (exhaustruct)
internal/cache/option_test.go|135 col 13| cache.cache is missing fields expireDur, expireCheckDur, expiredHook (exhaustruct)
internal/cache/option_test.go|145 col 13| cache.cache is missing fields cacher, expireDur, expireCheckDur, expiredHook (exhaustruct)
internal/cache/option_test.go|207 col 13| cache.cache is missing fields cacher, expireCheckDur, expiredHook (exhaustruct)
internal/cache/option_test.go|217 col 13| cache.cache is missing fields cacher, expireDur, expireCheckDur, expiredHook (exhaustruct)
internal/cache/option_test.go|291 col 13| cache.cache is missing fields cacher, expireDur, expiredHook (exhaustruct)
internal/net/net.go|237 col 30| mnd: Magic number: 2, in detected (gomnd)
internal/net/grpc/client.go|562 col 19| mnd: Magic number: 2, in detected (gomnd)
internal/slices/slices.go|34 col 14| mnd: Magic number: 2, in detected (gomnd)
internal/strings/strings.go|56 col 43| mnd: Magic number: 1024, in detected (gomnd)
cmd/agent/core/ngt/main_test.go|30 col 12| fieldalignment: struct with 40 pointer bytes could be 32 (govet)
cmd/agent/sidecar/main_test.go|30 col 12| fieldalignment: struct with 40 pointer bytes could be 32 (govet)
hack/helm/schema/crd/main_test.go|107 col 12| fieldalignment: struct with 80 pointer bytes could be 64 (govet)
hack/helm/schema/crd/main_test.go|195 col 12| fieldalignment: struct with 88 pointer bytes could be 72 (govet)
hack/helm/schema/crd/main_test.go|284 col 12| fieldalignment: struct with 88 pointer bytes could be 72 (govet)
hack/helm/schema/crd/main_test.go|372 col 12| fieldalignment: struct with 56 pointer bytes could be 48 (govet)
hack/helm/schema/crd/main_test.go|458 col 12| fieldalignment: struct with 80 pointer bytes could be 64 (govet)
hack/helm/schema/gen/main_test.go|106 col 12| fieldalignment: struct with 72 pointer bytes could be 64 (govet)
hack/helm/schema/gen/main_test.go|193 col 12| fieldalignment: struct with 112 pointer bytes could be 96 (govet)
internal/singleflight/singleflight.go|51 col 1| Do returns interface (V) (ireturn)
internal/cache/gache/gache.go|36 col 1| New returns interface (github.com/vdaas/vald/internal/cache/cacher.Cache) (ireturn)
internal/cache/cache.go|37 col 1| New returns interface (github.com/vdaas/vald/internal/cache/cacher.Cache) (ireturn)
internal/errgroup/group.go|55 col 1| New returns interface (github.com/vdaas/vald/internal/errgroup.Group) (ireturn)
internal/errgroup/group.go|74 col 1| Get returns interface (github.com/vdaas/vald/internal/errgroup.Group) (ireturn)
internal/client/v1/client/discoverer/discover_test.go|1396 col 22| Info_Nodes contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
internal/client/v1/client/discoverer/discover_test.go|1404 col 34| Info_Nodes contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
internal/client/v1/client/discoverer/discover_test.go|1408 col 53| Info_Nodes contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
internal/client/v1/client/filter/egress/client_test.go|535 col 17| Object_Distance contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
internal/client/v1/client/filter/egress/client_test.go|543 col 20| Object_Distance contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
internal/client/v1/client/filter/egress/client_test.go|871 col 17| Object_Vector contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
internal/client/v1/client/filter/egress/client_test.go|879 col 20| Object_Vector contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
internal/client/v1/client/filter/ingress/client_test.go|535 col 17| Object_Blob contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
internal/client/v1/client/filter/ingress/client_test.go|759 col 17| Object_Blob contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
internal/client/v1/client/filter/ingress/client_test.go|983 col 17| Object_Blob contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
internal/client/v1/client/vald/vald_test.go|511 col 17| Object_ID contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
internal/client/v1/client/vald/vald_test.go|519 col 20| Object_ID contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
internal/client/v1/client/vald/vald_test.go|623 col 17| Search_Request contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
internal/client/v1/client/vald/vald_test.go|631 col 20| Search_Response contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
internal/client/v1/client/vald/vald_test.go|639 col 34| Search_Response contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
internal/client/v1/client/vald/vald_test.go|735 col 17| Search_IDRequest contains underscore. You should use mixedCap or MixedCap. (nosnakecase)
pkg/gateway/lb/handler/grpc/handler_test.go|247 col 4| ST1003: var gotId should be gotID (stylecheck)
pkg/gateway/lb/handler/grpc/handler_test.go|384 col 4| ST1003: var gotId should be gotID (stylecheck)
cmd/agent/core/ngt/main_test.go|76 col 25| parameter name 'tt' is too short for the scope of its usage (varnamelen)
cmd/agent/sidecar/main_test.go|76 col 25| parameter name 'tt' is too short for the scope of its usage (varnamelen)
cmd/discoverer/k8s/main_test.go|76 col 25| parameter name 'tt' is too short for the scope of its usage (varnamelen)
internal/cache/cache.go|38 col 2| variable name 'c' is too short for the scope of its usage (varnamelen)
internal/cache/option.go|58 col 14| parameter name 'c' is too short for the scope of its usage (varnamelen)
internal/cache/option.go|46 col 15| parameter name 'mo' is too short for the scope of its usage (varnamelen)
internal/cache/option.go|72 col 14| parameter name 'c' is too short for the scope of its usage (varnamelen)
internal/cache/gache/gache_test.go|80 col 4| variable name 'c' is too short for the scope of its usage (varnamelen)
internal/cache/gache/gache_test.go|180 col 4| variable name 'c' is too short for the scope of its usage (varnamelen)
internal/cache/gache/option_test.go|122 col 4| variable name 'ga' is too short for the scope of its usage (varnamelen)
internal/cache/gache/gache_test.go|402 col 27| parameter name 'w' is too short for the scope of its usage (varnamelen)
internal/cache/gache/option_test.go|46 col 27| parameter name 'w' is too short for the scope of its usage (varnamelen)
internal/cache/gache/gache_test.go|318 col 27| parameter name 'w' is too short for the scope of its usage (varnamelen)
internal/circuitbreaker/breaker_test.go|814 col 4| variable name 'b' is too short for the scope of its usage (varnamelen)
internal/circuitbreaker/manager.go|75 col 6| variable name 'br' is too short for the scope of its usage (varnamelen)
internal/circuitbreaker/breaker_test.go|682 col 4| variable name 'b' is too short for the scope of its usage (varnamelen)
internal/circuitbreaker/manager.go|77 col 2| variable name 'ok' is too short for the scope of its usage (varnamelen)
internal/singleflight/singleflight_test.go|111 col 4| directive //nolint:unparam is unused for linter "unparam" (nolintlint)
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| package kvs |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
14-273 lines are duplicate of pkg/agent/core/ngt/service/kvs/uo.go:14-272 (dupl)
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| package kvs |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
14-272 lines are duplicate of pkg/agent/core/ngt/service/kvs/ou.go:14-273 (dupl)
| return nil | ||
| } | ||
| tests := []test{ | ||
| // TODO test cases |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
internal/test/goleak/goleak_test.go:40: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
| }, | ||
| */ | ||
|
|
||
| // TODO test cases |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
internal/test/goleak/goleak_test.go:59: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
| return nil | ||
| } | ||
| tests := []test{ | ||
| // TODO test cases |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
internal/test/goleak/goleak_test.go:123: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
| }, | ||
| */ | ||
|
|
||
| // TODO test cases |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
internal/observability/attribute/attribute_test.go:244: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
| return nil | ||
| } | ||
| tests := []test{ | ||
| // TODO test cases |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
internal/observability/attribute/attribute_test.go:313: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
| }, | ||
| */ | ||
|
|
||
| // TODO test cases |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
internal/observability/attribute/attribute_test.go:332: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
| return nil | ||
| } | ||
| tests := []test{ | ||
| // TODO test cases |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
internal/conv/conv_test.go:410: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
| }, | ||
| */ | ||
|
|
||
| // TODO test cases |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
internal/conv/conv_test.go:428: Line contains TODO/BUG/FIXME: "TODO test cases" (godox)
Description:
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: