Add implementation for save index job #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
team/set
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
[WARNING:INTCFG] Changes in |
Deploying with
|
| Latest commit: |
90cea88
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://52f66bff.vald.pages.dev |
| Branch Preview URL: | https://feature-index-job-save.vald.pages.dev |
Codecov ReportAttention:
... and 7 files with indirect coverage changes 📢 Thoughts on this report? Let us know! |
hlts2
changed the title
hlts2
force-pushed
the
feature/index-job/save
branch
from
13f9e44 to
82230bb
Compare
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
hlts2
force-pushed
the
feature/index-job/save
branch
from
82230bb to
78f349a
Compare
Signed-off-by: hlts2 <[email protected]>
ykadowak
previously approved these changes
Nov 8, 2023
Signed-off-by: hlts2 <[email protected]>
ykadowak
previously approved these changes
Nov 8, 2023
vankichi
requested changes
Nov 8, 2023
vankichi
previously approved these changes
Nov 8, 2023
Signed-off-by: hlts2 <[email protected]>
ykadowak
approved these changes
Nov 8, 2023
vankichi
approved these changes
Nov 8, 2023
Merged
kmrmt
pushed a commit
that referenced
this pull request
Dec 12, 2023
* add index save implementation Signed-off-by: hlts2 <[email protected]> * make gotest/gen and make format Signed-off-by: hlts2 <[email protected]> * fix: sample configuration data Signed-off-by: hlts2 <[email protected]> * feat: add save indexing test Signed-off-by: hlts2 <[email protected]> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 84ade79 according to the output from Gofumpt and Prettier. Details: #2227 * fix: deleted unnecessary code Signed-off-by: hlts2 <[email protected]> * fix: update debug error message Signed-off-by: hlts2 <[email protected]> * fix: option name Signed-off-by: hlts2 <[email protected]> * fix: test case name Signed-off-by: hlts2 <[email protected]> * Update cmd/index/job/save/sample.yaml Co-authored-by: Kiichiro YUKAWA <[email protected]> * Update pkg/index/job/save/config/config.go Co-authored-by: Kiichiro YUKAWA <[email protected]> * fix: add comment for test case Signed-off-by: hlts2 <[email protected]> * fix: fix method naming Signed-off-by: hlts2 <[email protected]> * feat: add mock for discoverer client and grpc client Signed-off-by: hlts2 <[email protected]> * fix: struct tag for config Signed-off-by: hlts2 <[email protected]> * fix: cyclic import for testing Signed-off-by: hlts2 <[email protected]> --------- Signed-off-by: hlts2 <[email protected]> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Kiichiro YUKAWA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I added a component to execute the
saveIndexrequests to agents.This component will run as a k8s job in the future.
NOTE
This component name is
index-saveto match the naming of the other components (index-correction,index-creation). This may change in the future at the time of refactoring.Related Issue:
Versions:
Checklist:
Special notes for your reviewer: