Add implementation for create index job #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
c188e66
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://791326cb.vald.pages.dev |
| Branch Preview URL: | https://feature-index-job-create.vald.pages.dev |
github-actions
bot
added
team/sre
|
[WARNING:INTCFG] Changes in |
|
[CHATOPS:HELP] ChatOps commands.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ENV APP_NAME index-creation | ||
|
|
||
| # skipcq: DOK-DL3008 | ||
| RUN apt-get update && apt-get install -y --no-install-recommends \ |
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Codecov ReportAttention:
... and 3 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
hlts2
requested review from
a team,
kmrmt,
datelier and
ykadowak
and removed request for
a team
ykadowak
approved these changes
Nov 2, 2023
hlts2
changed the title
datelier
approved these changes
Nov 6, 2023
Merged
kmrmt
pushed a commit
that referenced
this pull request
Dec 12, 2023
* feat: add index creation job implementation Signed-off-by: hlts2 <[email protected]> * feat: make format Signed-off-by: hlts2 <[email protected]> * fix: deepsource warning Signed-off-by: hlts2 <[email protected]> * fix: reviewdog warning and rename config file Signed-off-by: hlts2 <[email protected]> * feat: add mock for testing Signed-off-by: hlts2 <[email protected]> * feat: generate test code Signed-off-by: hlts2 <[email protected]> * fix: make format Signed-off-by: hlts2 <[email protected]> * feat: add test for indexing service Signed-off-by: hlts2 <[email protected]> * fix: improve grpc status handling Signed-off-by: hlts2 <[email protected]> * fix: docker build error Signed-off-by: hlts2 <[email protected]> * fix: deepsource warning Signed-off-by: hlts2 <[email protected]> * fix: start discoverer client before the logic is executed Signed-off-by: hlts2 <[email protected]> * fix: log message and sample data Signed-off-by: hlts2 <[email protected]> * fix: generate test and format Signed-off-by: hlts2 <[email protected]> --------- Signed-off-by: hlts2 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I added a component to execute the
createIndexrequests to agents.This component will run as a k8s job in the future.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: