-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve index correction performance #2234
Conversation
Deploying with Cloudflare Pages
|
[CHATOPS:HELP] ChatOps commands.
|
|
||
<a name="payload-v1-Info"></a> | ||
Provides links to documentation or for performing an out of band action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[LanguageTool] reported by reviewdog 🐶
Did you mean “out-of-band”? (OUT_OF_PLACE[1])
Suggestions: out-of-band
URL: https://languagetool.org/insights/post/hyphen/#hyphenated-phrases-with-more-than-one-hyphen
Rule: https://community.languagetool.org/rule/show/OUT_OF_PLACE?lang=en-US&subId=1
Category: PUNCTUATION
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2234 +/- ##
==========================================
+ Coverage 30.69% 30.73% +0.04%
==========================================
Files 358 358
Lines 34996 35095 +99
==========================================
+ Hits 10741 10786 +45
- Misses 23752 23803 +51
- Partials 503 506 +3 ☔ View full report in Codecov by Sentry. |
stream test
Profile Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* Add GetObjectMeta rpc in proto * Compile GetObjectMeta * Implement GetObjectMeta * Add test for GetObjectMeta * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 924903d according to the output from Gofumpt and Prettier. Details: #2234 * Add GetObjectMeta client * Change to use GetObjectMeta in corrector logic * Rename rpc to GetTimestamp * Update test to check all the data set * Remove unused code in correct function * Add error handling for empty returned vectors in stream test * Add fillVectorField when there is none * Reverse agentAddrs to decrease broadcast * process the reverse order of number of indexes * Refactor loadInfos function to loadAgentIndexInfo * declare slice as empty slice for deepsource * Add comment * Add eg.Wait --------- Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Description:
GetTimestamp
rpc in agent. This is for reducing network bandwidth by not sending vector data itself, which is not required to correct index. This has a lot of impact when network quality is low.Overall this PR reduces processing time by 30% compared to the worst case.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: