Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tune default params & small bug fix #2100

Merged
merged 2 commits into from
Jul 4, 2023
Merged

tune default params & small bug fix #2100

merged 2 commits into from
Jul 4, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jun 30, 2023

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.20.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.13

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kpango kpango requested review from a team, kmrmt, hlts2 and vankichi and removed request for a team and hlts2 June 30, 2023 05:14
@kpango
tune default params
ede7f50 
Signed-off-by: kpango <[email protected]>
@kpango kpango force-pushed the performance/grpc/tune-grpc-server-and-client-default-params branch from 1123651 to ede7f50 Compare June 30, 2023 05:39
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 30, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d0414a4
Status:⚡️  Build in progress...

View logs

@codecov
Copy link

codecov bot commented Jun 30, 2023 •
edited
Loading

Codecov Report

Patch coverage: 11.11% and project coverage change: +0.04 🎉

Comparison is base (7689577) 29.93% compared to head (ede7f50) 29.97%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2100      +/-   ##
==========================================
+ Coverage   29.93%   29.97%   +0.04%     
==========================================
  Files         369      369              
  Lines       35086    35091       +5     
==========================================
+ Hits        10503    10519      +16     
+ Misses      24100    24090      -10     
+ Partials      483      482       -1
Impacted Files Coverage Δ
hack/helm/schema/gen/main.go 0.00% <0.00%> (ø)
pkg/gateway/lb/handler/grpc/aggregation.go 0.00% <0.00%> (ø)
internal/core/algorithm/ngt/ngt.go 62.33% <100.00%> (-0.09%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kpango kpango changed the title tune default params tune default params & small bug fix Jul 3, 2023
@kpango kpango merged commit a46ac9e into main Jul 4, 2023
@kpango kpango deleted the performance/grpc/tune-grpc-server-and-client-default-params branch July 4, 2023 01:24
kpango added a commit that referenced this pull request Jul 5, 2023
@kpango
Revert "tune default params (#2100)"
a03e072 
This reverts commit a46ac9e.

Signed-off-by: kpango <[email protected]>
kpango added a commit that referenced this pull request Jul 6, 2023
@kpango
Revert "tune default params (#2100)"
784807f 
This reverts commit a46ac9e.

Signed-off-by: kpango <[email protected]>
kpango added a commit that referenced this pull request Jul 6, 2023
@kpango
Revert "tune default params (#2100)"
0e3b9ef 
This reverts commit a46ac9e.

Signed-off-by: kpango <[email protected]>
kpango added a commit that referenced this pull request Jul 6, 2023
@kpango
Revert "tune default params (#2100)"
49ebf7d 
Signed-off-by: kpango <[email protected]>
kpango added a commit that referenced this pull request Jul 6, 2023
@kpango
Revert "tune default params (#2100)"
dd73e4a 
Signed-off-by: kpango <[email protected]>
kpango added a commit that referenced this pull request Jul 6, 2023
@kpango
Revert "tune default params (#2100)"
1359dcf 
Signed-off-by: kpango <[email protected]>
kpango added a commit that referenced this pull request Jul 6, 2023
@kpango
Revert "tune default params (#2100)"
2729c1b 
Signed-off-by: kpango <[email protected]>
kpango added a commit that referenced this pull request Jul 6, 2023
@kpango
Revert "tune default params (#2100)"
38d60ab 
Signed-off-by: kpango <[email protected]>
kpango added a commit that referenced this pull request Jul 11, 2023
@kpango
Revert "tune default params (#2100)" (#2111)
9774624 
Signed-off-by: kpango <[email protected]>
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Merged
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Revert "tune default params (#2100)" (#2111)"
d453cb3 
This reverts commit 9774624.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "tune default params (#2100)"
6af15e8 
This reverts commit a46ac9e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vankichi vankichi vankichi approved these changes

@kmrmt kmrmt kmrmt approved these changes

Assignees
No one assigned
Labels
area/gateway/lb area/helm area/internal priority/low size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpango @vdaas-ci @kmrmt @vankichi