Skip to content

Commit

Permalink
Revert "tune default params (#2100)"
Browse files Browse the repository at this point in the history 
This reverts commit a46ac9e.

Signed-off-by: kpango <[email protected]>
  • Loading branch information
@kpango
kpango committed Jul 5, 2023
1 parent ffc0492 commit a03e072
Show file tree
Hide file tree
Showing 18 changed files with 373 additions and 411 deletions.
64 changes: 32 additions & 32 deletions charts/vald/README.md
View file

Large diffs are not rendered by default.

16 changes: 0 additions & 16 deletions charts/vald/templates/_helpers.tpl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -440,22 +440,6 @@ startup_strategy:
{{- if $readinessEnabled }}
- readiness
{{- end }}
shutdown_strategy:
{{- if $readinessEnabled }}
- readiness
{{- end }}
{{- if $restEnabled }}
- rest
{{- end }}
{{- if $grpcEnabled }}
- grpc
{{- end }}
{{- if $pprofEnabled }}
- pprof
{{- end }}
{{- if $livenessEnabled }}
- liveness
{{- end }}
full_shutdown_duration: {{ default .default.full_shutdown_duration .Values.full_shutdown_duration }}
tls:
{{- if .Values.tls }}
Expand Down
336 changes: 168 additions & 168 deletions charts/vald/values.schema.json
View file

Large diffs are not rendered by default.

88 changes: 46 additions & 42 deletions charts/vald/values.yaml
View file

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions go.mod
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ replace (
github.com/ajstarks/svgo => github.com/ajstarks/svgo v0.0.0-20211024235047-1546f124cd8b
github.com/antihax/optional => github.com/antihax/optional v1.0.0
github.com/armon/go-socks5 => github.com/armon/go-socks5 v0.0.0-20160902184237-e75332964ef5
github.com/aws/aws-sdk-go => github.com/aws/aws-sdk-go v1.44.293
github.com/aws/aws-sdk-go => github.com/aws/aws-sdk-go v1.44.295
github.com/aws/aws-sdk-go-v2 => github.com/aws/aws-sdk-go-v2 v1.18.1
github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream => github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.4.10
github.com/aws/aws-sdk-go-v2/config => github.com/aws/aws-sdk-go-v2/config v1.18.27
Expand Down Expand Up @@ -190,7 +190,7 @@ replace (
github.com/jstemmer/go-junit-report => github.com/jstemmer/go-junit-report v1.0.0
github.com/kisielk/errcheck => github.com/kisielk/errcheck v1.6.3
github.com/kisielk/gotool => github.com/kisielk/gotool v1.0.0
github.com/klauspost/compress => github.com/klauspost/compress v1.16.7-0.20230622111944-67a538e2b4df
github.com/klauspost/compress => github.com/klauspost/compress v1.16.7
github.com/klauspost/cpuid/v2 => github.com/klauspost/cpuid/v2 v2.2.5
github.com/kpango/fastime => github.com/kpango/fastime v1.1.9
github.com/kpango/fuid => github.com/kpango/fuid v0.0.0-20221203053508-503b5ad89aa1
Expand Down Expand Up @@ -244,7 +244,7 @@ replace (
github.com/quasilyte/gogrep => github.com/quasilyte/gogrep v0.5.0
github.com/quasilyte/stdinfo => github.com/quasilyte/stdinfo v0.0.0-20220114132959-f7386bf02567
github.com/rogpeppe/fastuuid => github.com/rogpeppe/fastuuid v1.2.0
github.com/rogpeppe/go-internal => github.com/rogpeppe/go-internal v1.10.0
github.com/rogpeppe/go-internal => github.com/rogpeppe/go-internal v1.11.0
github.com/rs/xid => github.com/rs/xid v1.5.0
github.com/rs/zerolog => github.com/rs/zerolog v1.29.1
github.com/russross/blackfriday/v2 => github.com/russross/blackfriday/v2 v2.1.0
Expand All @@ -254,8 +254,8 @@ replace (
github.com/scylladb/gocqlx => github.com/scylladb/gocqlx v1.5.0
github.com/sergi/go-diff => github.com/sergi/go-diff v1.3.1
github.com/shopspring/decimal => github.com/shopspring/decimal v1.3.1
github.com/shurcooL/httpfs => github.com/shurcooL/httpfs v0.0.0-20190707220628-8d4bc4ba7749
github.com/shurcooL/vfsgen => github.com/shurcooL/vfsgen v0.0.0-20200824052919-0d455de96546
github.com/shurcooL/httpfs => github.com/shurcooL/httpfs v0.0.0-20230704072500-f1e31cf0ba5c
github.com/shurcooL/vfsgen => github.com/shurcooL/vfsgen v0.0.0-20230704071429-0000e147ea92
github.com/sirupsen/logrus => github.com/sirupsen/logrus v1.9.3
github.com/spf13/afero => github.com/spf13/afero v1.9.5
github.com/spf13/cobra => github.com/spf13/cobra v1.7.0
Expand Down Expand Up @@ -296,13 +296,13 @@ replace (
golang.org/x/image => golang.org/x/image v0.8.0
golang.org/x/lint => golang.org/x/lint v0.0.0-20210508222113-6edffad5e616
golang.org/x/mobile => golang.org/x/mobile v0.0.0-20230531173138-3c911d8e3eda
golang.org/x/mod => golang.org/x/mod v0.11.0
golang.org/x/mod => golang.org/x/mod v0.12.0
golang.org/x/net => golang.org/x/net v0.11.0
golang.org/x/oauth2 => golang.org/x/oauth2 v0.9.0
golang.org/x/sync => golang.org/x/sync v0.3.0
golang.org/x/sys => golang.org/x/sys v0.9.0
golang.org/x/sys => golang.org/x/sys v0.10.0
golang.org/x/term => golang.org/x/term v0.9.0
golang.org/x/text => golang.org/x/text v0.10.0
golang.org/x/text => golang.org/x/text v0.11.0
golang.org/x/time => golang.org/x/time v0.3.0
golang.org/x/tools => golang.org/x/tools v0.10.0
golang.org/x/xerrors => golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2
Expand Down
28 changes: 14 additions & 14 deletions go.sum
View file
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,8 @@ github.com/antihax/optional v1.0.0/go.mod h1:uupD/76wgC+ih3iEmQUL+0Ugr19nfwCT1kd
github.com/apache/arrow/go/v12 v12.0.0/go.mod h1:d+tV/eHZZ7Dz7RPrFKtPK02tpr+c9/PEd/zm8mDS9Vg=
github.com/apache/thrift v0.16.0/go.mod h1:PHK3hniurgQaNMZYaCLEqXKsYK8upmhPbmdP2FXSqgU=
github.com/armon/go-socks5 v0.0.0-20160902184237-e75332964ef5 h1:0CwZNZbxp69SHPdPJAN/hZIm0C4OItdklCFmMRWYpio=
github.com/aws/aws-sdk-go v1.44.293 h1:oBPrQqsyMYe61Sl/xKVvQFflXjPwYH11aKi8QR3Nhts=
github.com/aws/aws-sdk-go v1.44.293/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI=
github.com/aws/aws-sdk-go v1.44.295 h1:SGjU1+MqttXfRiWHD6WU0DRhaanJgAFY+xIhEaugV8Y=
github.com/aws/aws-sdk-go v1.44.295/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI=
github.com/aws/aws-sdk-go-v2 v1.18.1 h1:+tefE750oAb7ZQGzla6bLkOwfcQCEtC5y2RqoqCeqKo=
github.com/aws/aws-sdk-go-v2 v1.18.1/go.mod h1:uzbQtefpm44goOPmdKyAlXSNcwlRgF3ePWVW6EtJvvw=
github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.4.10 h1:dK82zF6kkPeCo8J1e+tGx4JdvDIQzj7ygIoLg8WMuGs=
Expand Down Expand Up @@ -495,8 +495,8 @@ github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51/go.mod h1:C
github.com/kisielk/errcheck v1.6.3/go.mod h1:nXw/i/MfnvRHqXa7XXmQMUB0oNFGuBrNI8d8NLy0LPw=
github.com/kisielk/gotool v1.0.0/go.mod h1:XhKaO+MFFWcvkIS/tQcRk01m1F5IRFswLeQ+oQHNcck=
github.com/klauspost/asmfmt v1.3.2/go.mod h1:AG8TuvYojzulgDAMCnYn50l/5QV3Bs/tp6j0HLHbNSE=
github.com/klauspost/compress v1.16.7-0.20230622111944-67a538e2b4df h1:YVmtlF3q1+H7fzHO2iCZ6n/LmfF3HfqshO/jIqbqpRU=
github.com/klauspost/compress v1.16.7-0.20230622111944-67a538e2b4df/go.mod h1:ntbaceVETuRiXiv4DpjP66DpAtAGkEQskQzEyD//IeE=
github.com/klauspost/compress v1.16.7 h1:2mk3MPGNzKyxErAw8YaohYh69+pa4sIQSC0fPGCFR9I=
github.com/klauspost/compress v1.16.7/go.mod h1:ntbaceVETuRiXiv4DpjP66DpAtAGkEQskQzEyD//IeE=
github.com/klauspost/cpuid/v2 v2.2.5 h1:0E5MSMDEoAulmXNFquVs//DdoomxaoTY1kUhbc/qbZg=
github.com/klauspost/cpuid/v2 v2.2.5/go.mod h1:Lcz8mBdAVJIBVzewtcLocK12l3Y+JytZYpaMropDUws=
github.com/kpango/fastime v1.1.9 h1:xVQHcqyPt5M69DyFH7g1EPRns1YQNap9d5eLhl/Jy84=
Expand Down Expand Up @@ -604,8 +604,8 @@ github.com/rakyll/embedmd v0.0.0-20171029212350-c8060a0752a2/go.mod h1:7jOTMgqac
github.com/remyoudompheng/bigfft v0.0.0-20200410134404-eec4a21b6bb0/go.mod h1:qqbHyh8v60DhA7CoWK5oRCqLrMHRGoxYCSS9EjAz6Eo=
github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec/go.mod h1:qqbHyh8v60DhA7CoWK5oRCqLrMHRGoxYCSS9EjAz6Eo=
github.com/rogpeppe/fastuuid v1.2.0/go.mod h1:jVj6XXZzXRy/MSR5jhDC/2q6DgLz+nrA6LYCDYWNEvQ=
github.com/rogpeppe/go-internal v1.10.0 h1:TMyTOH3F/DB16zRVcYyreMH6GnZZrwQVAoYjRBZyWFQ=
github.com/rogpeppe/go-internal v1.10.0/go.mod h1:UQnix2H7Ngw/k4C5ijL5+65zddjncjaFoBhdsK/akog=
github.com/rogpeppe/go-internal v1.11.0 h1:cWPaGQEPrBb5/AsnsZesgZZ9yb1OQ+GOISoDNXVBh4M=
github.com/rogpeppe/go-internal v1.11.0/go.mod h1:ddIwULY96R17DhadqLgMfk9H9tvdUzkipdSkR5nkCZA=
github.com/rs/xid v1.5.0/go.mod h1:trrq9SKmegXys3aeAKXMUTdJsYXVwGY3RLcfgqegfbg=
github.com/rs/zerolog v1.29.1/go.mod h1:Le6ESbR7hc+DP6Lt1THiV8CQSdkkNrd3R0XbEgp3ZBU=
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
Expand All @@ -618,8 +618,8 @@ github.com/scylladb/gocqlx v1.5.0/go.mod h1:QarZcw5kpYh31MXfxiN2JWWvF1cgZbYqfTfX
github.com/sergi/go-diff v1.3.1 h1:xkr+Oxo4BOQKmkn/B9eMK0g5Kg/983T9DqqPHwYqD+8=
github.com/shopspring/decimal v1.3.1/go.mod h1:DKyhrW/HYNuLGql+MJL6WCR6knT2jwCFRcu2hWCYk4o=
github.com/shurcooL/go v0.0.0-20200502201357-93f07166e636/go.mod h1:TDJrrUr11Vxrven61rcy3hJMUqaf/CLWYhHNPmT14Lk=
github.com/shurcooL/httpfs v0.0.0-20190707220628-8d4bc4ba7749/go.mod h1:ZY1cvUeJuFPAdZ/B6v7RHavJWZn2YPVFQ1OSXhCGOkg=
github.com/shurcooL/vfsgen v0.0.0-20200824052919-0d455de96546/go.mod h1:TrYk7fJVaAttu97ZZKrO9UbRa8izdowaMIZcxYMbVaw=
github.com/shurcooL/httpfs v0.0.0-20230704072500-f1e31cf0ba5c/go.mod h1:owqhoLW1qZoYLZzLnBw+QkPP9WZnjlSWihhxAJC1+/M=
github.com/shurcooL/vfsgen v0.0.0-20230704071429-0000e147ea92/go.mod h1:7/OT02F6S6I7v6WXb+IjhMuZEYfH/RJ5RwEWnEo5BMg=
github.com/sirupsen/logrus v1.9.3 h1:dueUQJ1C2q9oE3F7wvmSGAaVtTmUizReu6fjN8uqzbQ=
github.com/sirupsen/logrus v1.9.3/go.mod h1:naHLuLoDiP4jHNo9R0sCBMtWGeIprob74mVsIT4qYEQ=
github.com/spf13/afero v1.9.5/go.mod h1:UBogFpq8E9Hx+xc5CNTTEpTnuHVmXDwZcZcE1eb/UhQ=
Expand Down Expand Up @@ -706,20 +706,20 @@ golang.org/x/image v0.8.0 h1:agUcRXV/+w6L9ryntYYsF2x9fQTMd4T8fiiYXAVW6Jg=
golang.org/x/image v0.8.0/go.mod h1:PwLxp3opCYg4WR2WO9P0L6ESnsD6bLTWcw8zanLMVFM=
golang.org/x/lint v0.0.0-20210508222113-6edffad5e616/go.mod h1:3xt1FjdF8hUf6vQPIChWIBhFzV8gjjsPE/fR3IyQdNY=
golang.org/x/mobile v0.0.0-20230531173138-3c911d8e3eda/go.mod h1:aAjjkJNdrh3PMckS4B10TGS2nag27cbKR1y2BpUxsiY=
golang.org/x/mod v0.11.0 h1:bUO06HqtnRcc/7l71XBe4WcqTZ+3AH1J59zWDDwLKgU=
golang.org/x/mod v0.11.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
golang.org/x/mod v0.12.0 h1:rmsUpXtvNzj340zd98LZ4KntptpfRHwpFOHG188oHXc=
golang.org/x/mod v0.12.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
golang.org/x/net v0.11.0 h1:Gi2tvZIJyBtO9SDr1q9h5hEQCp/4L2RQ+ar0qjx2oNU=
golang.org/x/net v0.11.0/go.mod h1:2L/ixqYpgIVXmeoSA/4Lu7BzTG4KIyPIryS4IsOd1oQ=
golang.org/x/oauth2 v0.9.0 h1:BPpt2kU7oMRq3kCHAA1tbSEshXRw1LpG2ztgDwrzuAs=
golang.org/x/oauth2 v0.9.0/go.mod h1:qYgFZaFiu6Wg24azG8bdV52QJXJGbZzIIsRCdVKzbLw=
golang.org/x/sync v0.3.0 h1:ftCYgMx6zT/asHUrPw8BLLscYtGznsLAnjq5RH9P66E=
golang.org/x/sync v0.3.0/go.mod h1:FU7BRWz2tNW+3quACPkgCx/L+uEAv1htQ0V83Z9Rj+Y=
golang.org/x/sys v0.9.0 h1:KS/R3tvhPqvJvwcKfnBHJwwthS11LRhmM5D59eEXa0s=
golang.org/x/sys v0.9.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.10.0 h1:SqMFp9UcQJZa+pmYuAKjd9xq1f0j5rLcDIk0mj4qAsA=
golang.org/x/sys v0.10.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/term v0.9.0 h1:GRRCnKYhdQrD8kfRAdQ6Zcw1P0OcELxGLKJvtjVMZ28=
golang.org/x/term v0.9.0/go.mod h1:M6DEAAIenWoTxdKrOltXcmDY3rSplQUkrvaDU5FcQyo=
golang.org/x/text v0.10.0 h1:UpjohKhiEgNc0CSauXmwYftY1+LlaC75SJwh0SgCX58=
golang.org/x/text v0.10.0/go.mod h1:TvPlkZtksWOMsz7fbANvkp4WM8x/WCo/om8BMLbz+aE=
golang.org/x/text v0.11.0 h1:LAntKIrcmeSKERyiOh0XMV39LXS8IE9UL2yP7+f5ij4=
golang.org/x/text v0.11.0/go.mod h1:TvPlkZtksWOMsz7fbANvkp4WM8x/WCo/om8BMLbz+aE=
golang.org/x/time v0.3.0 h1:rg5rLMjNzMS1RkNLzCG38eapWhnYLFYXDXj2gOlr8j4=
golang.org/x/time v0.3.0/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
golang.org/x/tools v0.10.0 h1:tvDr/iQoUqNdohiYm0LmmKcBk+q86lb9EprIUFhHHGg=
Expand Down
3 changes: 2 additions & 1 deletion internal/core/algorithm/ngt/ngt.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -664,8 +664,9 @@ func (n *ngt) BulkRemove(ids ...uint) (errs error) {
}

// GetVector returns vector stored in NGT index.
func (n *ngt) GetVector(id uint) (ret []float32, err error) {
func (n *ngt) GetVector(id uint) ([]float32, error) {
dimension := int(n.dimension)
var ret []float32
ebuf := n.GetErrorBuffer()
switch n.objectType {
case Float:
Expand Down
37 changes: 16 additions & 21 deletions k8s/agent/configmap.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,18 @@ data:
connection_timeout: ""
enable_reflection: true
header_table_size: 0
initial_conn_window_size: 2097152
initial_window_size: 1048576
initial_conn_window_size: 0
initial_window_size: 0
interceptors:
- RecoverInterceptor
keepalive:
max_conn_age: ""
max_conn_age_grace: ""
max_conn_idle: ""
min_time: 10m
permit_without_stream: false
time: 3h
timeout: 60s
min_time: 60s
permit_without_stream: true
time: 120s
timeout: 30s
max_header_list_size: 0
max_receive_message_size: 0
max_send_message_size: 0
Expand All @@ -70,10 +70,10 @@ data:
ip_transparent: false
reuse_addr: true
reuse_port: true
tcp_cork: true
tcp_defer_accept: false
tcp_fast_open: false
tcp_no_delay: false
tcp_cork: false
tcp_defer_accept: true
tcp_fast_open: true
tcp_no_delay: true
tcp_quick_ack: true
socket_path: ""
health_check_servers:
Expand All @@ -96,7 +96,7 @@ data:
reuse_addr: true
reuse_port: true
tcp_cork: false
tcp_defer_accept: false
tcp_defer_accept: true
tcp_fast_open: true
tcp_no_delay: true
tcp_quick_ack: true
Expand All @@ -120,7 +120,7 @@ data:
reuse_addr: true
reuse_port: true
tcp_cork: false
tcp_defer_accept: false
tcp_defer_accept: true
tcp_fast_open: true
tcp_no_delay: true
tcp_quick_ack: true
Expand All @@ -144,22 +144,17 @@ data:
ip_transparent: false
reuse_addr: true
reuse_port: true
tcp_cork: true
tcp_defer_accept: false
tcp_fast_open: false
tcp_no_delay: false
tcp_cork: false
tcp_defer_accept: true
tcp_fast_open: true
tcp_no_delay: true
tcp_quick_ack: true
socket_path: ""
startup_strategy:
- liveness
- pprof
- grpc
- readiness
shutdown_strategy:
- readiness
- grpc
- pprof
- liveness
full_shutdown_duration: 600s
tls:
ca: /path/to/ca
Expand Down
37 changes: 16 additions & 21 deletions k8s/discoverer/configmap.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,18 @@ data:
connection_timeout: ""
enable_reflection: true
header_table_size: 0
initial_conn_window_size: 2097152
initial_window_size: 1048576
initial_conn_window_size: 0
initial_window_size: 0
interceptors:
- RecoverInterceptor
keepalive:
max_conn_age: ""
max_conn_age_grace: ""
max_conn_idle: ""
min_time: 10m
permit_without_stream: false
time: 3h
timeout: 60s
min_time: 60s
permit_without_stream: true
time: 120s
timeout: 30s
max_header_list_size: 0
max_receive_message_size: 0
max_send_message_size: 0
Expand All @@ -70,10 +70,10 @@ data:
ip_transparent: false
reuse_addr: true
reuse_port: true
tcp_cork: true
tcp_defer_accept: false
tcp_fast_open: false
tcp_no_delay: false
tcp_cork: false
tcp_defer_accept: true
tcp_fast_open: true
tcp_no_delay: true
tcp_quick_ack: true
socket_path: ""
health_check_servers:
Expand All @@ -96,7 +96,7 @@ data:
reuse_addr: true
reuse_port: true
tcp_cork: false
tcp_defer_accept: false
tcp_defer_accept: true
tcp_fast_open: true
tcp_no_delay: true
tcp_quick_ack: true
Expand All @@ -120,7 +120,7 @@ data:
reuse_addr: true
reuse_port: true
tcp_cork: false
tcp_defer_accept: false
tcp_defer_accept: true
tcp_fast_open: true
tcp_no_delay: true
tcp_quick_ack: true
Expand All @@ -144,22 +144,17 @@ data:
ip_transparent: false
reuse_addr: true
reuse_port: true
tcp_cork: true
tcp_defer_accept: false
tcp_fast_open: false
tcp_no_delay: false
tcp_cork: false
tcp_defer_accept: true
tcp_fast_open: true
tcp_no_delay: true
tcp_quick_ack: true
socket_path: ""
startup_strategy:
- liveness
- pprof
- grpc
- readiness
shutdown_strategy:
- readiness
- grpc
- pprof
- liveness
full_shutdown_duration: 600s
tls:
ca: /path/to/ca
Expand Down
2 changes: 1 addition & 1 deletion k8s/discoverer/deployment.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ spec:
app.kubernetes.io/instance: release-name
app.kubernetes.io/component: discoverer
annotations:
checksum/configmap: 93b7c3aa6b8f0c29c84cb8f89df27119858e4174f0956120fdc63b944ec85d11
checksum/configmap: 0b472fffedcc5bfab8f66d948b086fa1a016e1221a034f7794525bdf67b46827
profefe.com/enable: "true"
profefe.com/port: "6060"
profefe.com/service: vald-discoverer
Expand Down
Loading

0 comments on commit a03e072

Please sign in to comment.