Add index correction metrics #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| correctedOldIndexCountDesc = "The number of corrected old indexes while index correction job" | ||
|
|
||
| correctedReplicationCount = "index_job_correction_corrected_replication_count" | ||
| correctedReplicationCountDesc = "The number of operation happend to correct replication number while index correction job" |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶happend is a misspelling of happened (misspell)
Deploying with
|
| Latest commit: |
2e3d072
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f19d8a55.vald.pages.dev |
| Branch Preview URL: | https://feature-corrector-metrics.vald.pages.dev |
Codecov ReportAttention:
... and 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
internal/observability/metrics/index/job/correction/correction.go
Outdated
Show resolved
Hide resolved
ykadowak
changed the title
internal/observability/metrics/index/job/correction/correction.go
Outdated
Show resolved
Hide resolved
ykadowak
requested review from
a team,
kmrmt and
datelier
and removed request for
a team
kmrmt
approved these changes
Oct 26, 2023
datelier
approved these changes
Oct 30, 2023
Merged
kmrmt
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Add observability pkg for index correction * Add template grafana dashboard page of index correction * Update label * Add checked index count * Fix o11y service name * Add correction metrics fields in the grafana * Init correction metrics * Organized grafana dashboard for index correction * Fix misspell * Remove unused method receiver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds metrics for
index-correctionjob. Also added grafana dashboard forindex-correction.Added metrics:
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: