Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ingress resource in the getStarted document #2211

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Oct 17, 2023

Description:

This PR contains the following changes.

  • Enable Ingress resource in the example
  • go module update
  • Refactor deprecated code
  • Fix broken indent

Related Issue:

Versions:

  • Go Version: 1.21.3
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.2
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Signed-off-by: hlts2 <[email protected]>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bc00927
Status: ✅  Deploy successful!
Preview URL: https://fae19bc5.vald.pages.dev
Branch Preview URL: https://feature-docs-ingress-example.vald.pages.dev

View logs

This commit fixes the style issues introduced in ac6ee52 according to the output
from Gofumpt and Prettier.

Details: #2211
```

</details>
- Remove indexed 400 training datasets from the Vald agent.
Copy link
Collaborator Author

@hlts2 hlts2 Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 I fixed the indentation because it is broken.
image

👉 https://vald.vdaas.org/docs/tutorial/vald-agent-standalone-on-k8s/

@@ -236,7 +236,7 @@ This chapter uses [NGT](https://github.com/yahoojapan/ngt) as Vald Agent to perf
```go
ctx := context.Background()

conn, err := grpc.DialContext(ctx, grpcServerAddr, grpc.WithInsecure())
conn, err := grpc.DialContext(ctx, grpcServerAddr, grpc.WithTransportCredentials(insecure.NewCredentials()))
Copy link
Collaborator Author

@hlts2 hlts2 Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because WithInsecure is deprecated, I fixed it to use the WithTransportCredentials .

@hlts2 hlts2 self-assigned this Oct 17, 2023
@hlts2 hlts2 requested review from a team, kpango and vankichi and removed request for a team October 17, 2023 07:03
@@ -284,21 +284,23 @@ This chapter uses [NGT](https://github.com/yahoojapan/ngt) as Vald Agent to perf

</details>

- [Optional] Indexing manually instead of waiting for auto indexing
- [Optional] Indexing manually instead of waiting for auto indexing.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 I fixed the indentation because it is broken.
img

👉 https://vald.vdaas.org/docs/tutorial/vald-agent-standalone-on-k8s/

Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlts2 hlts2 merged commit a7a746f into main Oct 18, 2023
11 checks passed
@hlts2 hlts2 deleted the feature/docs/ingress-example branch October 18, 2023 01:03
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
@vankichi vankichi mentioned this pull request Dec 4, 2023
kmrmt pushed a commit that referenced this pull request Dec 12, 2023
* fix: enable ingress resource in the getStarted document and refactor

Signed-off-by: hlts2 <[email protected]>

* fix: indent bug

Signed-off-by: hlts2 <[email protected]>

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in ac6ee52 according to the output
from Gofumpt and Prettier.

Details: #2211

* fix expand format bug

Signed-off-by: hlts2 <[email protected]>

* fix: broken expand

Signed-off-by: hlts2 <[email protected]>

* fix: new line for visibility

Signed-off-by: hlts2 <[email protected]>

---------

Signed-off-by: hlts2 <[email protected]>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants