Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Generate test codes #2107

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Re-Generate test codes #2107

merged 1 commit into from
Jul 6, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jul 4, 2023

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.20.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.13

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 4, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

// }
// type test struct {
// name string
// want want
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dupword: Duplicate words (want) found

❗❗ 8 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding
File Path Line Number
internal/conv/conv_test.go 397
internal/conv/conv_test.go 398
internal/log/mock/logger_test.go 852
internal/log/mock/logger_test.go 853
internal/log/mock/logger_test.go 854
internal/log/mock/logger_test.go 985
internal/log/mock/logger_test.go 986
internal/log/mock/logger_test.go 1119

Visit the Lift Web Console to find more details in your report.


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

// }
// type test struct {
// name string
// want want
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Duplicate words (want) found (dupword)

// }
// type test struct {
// name string
// want want
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Duplicate words (want) found (dupword)

// }
// type test struct {
// name string
// want want
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Duplicate words (want) found (dupword)

// }
// type test struct {
// name string
// args args
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Duplicate words (args) found (dupword)

// }
// type test struct {
// name string
// args args
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Duplicate words (args) found (dupword)

// }
// type test struct {
// name string
// fields fields
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Duplicate words (fields) found (dupword)

// }
// type test struct {
// name string
// fields fields
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Duplicate words (fields) found (dupword)

// saveIndexWaitDuration time.Duration
// saveIndexTargetAddrCh chan string
// concurrency int
// indexInfos indexInfos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Duplicate words (indexInfos) found (dupword)

// saveIndexWaitDuration time.Duration
// saveIndexTargetAddrCh chan string
// concurrency int
// indexInfos indexInfos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Duplicate words (indexInfos) found (dupword)

// saveIndexWaitDuration time.Duration
// saveIndexTargetAddrCh chan string
// concurrency int
// indexInfos indexInfos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Duplicate words (indexInfos) found (dupword)

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.77 🎉

Comparison is base (a46ac9e) 29.89% compared to head (185239f) 30.66%.

❗ Current head 185239f differs from pull request most recent head a96a408. Consider uploading reports for the commit a96a408 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2107      +/-   ##
==========================================
+ Coverage   29.89%   30.66%   +0.77%     
==========================================
  Files         369      347      -22     
  Lines       35091    34255     -836     
==========================================
+ Hits        10489    10505      +16     
+ Misses      24118    23272     -846     
+ Partials      484      478       -6     

see 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a96a408
Status: ✅  Deploy successful!
Preview URL: https://02d4a260.vald.pages.dev
Branch Preview URL: https://test-re-generate-tests.vald.pages.dev

View logs

@vankichi vankichi force-pushed the test/re-generate-tests branch from 185239f to a96a408 Compare July 6, 2023 04:28
@vankichi vankichi merged commit a6d8701 into main Jul 6, 2023
@vankichi vankichi deleted the test/re-generate-tests branch July 6, 2023 04:34
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants