Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled CI to fail in case of format differences. #2226

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Nov 2, 2023

Description:

Format check job was successful, even if there were format differences.

Related Issue:

Versions:

  • Go Version: 1.21.3
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.2
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Nov 2, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@hlts2 hlts2 self-assigned this Nov 2, 2023
@github-actions github-actions bot added the size/S label Nov 2, 2023
@hlts2 hlts2 requested review from a team, kpango and vankichi and removed request for a team November 2, 2023 03:13
@hlts2 hlts2 merged commit 41cc83b into main Nov 2, 2023
16 checks passed
@hlts2 hlts2 deleted the fix-format-ci branch November 2, 2023 08:14
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
@vankichi vankichi mentioned this pull request Dec 4, 2023
kmrmt pushed a commit that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants