-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minikube to create volume snapshot development environment locally #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
team/sre
SRE team
area/makefile
size/M
type/feature
New feature
priority/medium
labels
Nov 6, 2023
ykadowak
force-pushed
the
feature/make/add-minikube
branch
from
November 6, 2023 07:42
16e7ea5
to
dc61346
Compare
ykadowak
changed the title
[WIP] Add minikube to create volume snapshot development environment locally
Add minikube to create volume snapshot development environment locally
Nov 6, 2023
ykadowak
requested review from
a team,
kpango and
hlts2
and removed request for
a team
November 6, 2023 08:01
kpango
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hlts2
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Merged
kmrmt
pushed a commit
that referenced
this pull request
Dec 12, 2023
#2228) * Add minikube to create volume snapshot development environment locally * Fix devcontainer build * Add triggers for devcontainer build * apply format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
To develop features related to volume cloning and snapshot, we need a local support of it. Unfortunately k3d does not support it but minikube does. So this PR adds minikube environment in makefile and devcontainer.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: