Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minikube to create volume snapshot development environment locally #2228

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Nov 6, 2023

Description:

To develop features related to volume cloning and snapshot, we need a local support of it. Unfortunately k3d does not support it but minikube does. So this PR adds minikube environment in makefile and devcontainer.

Related Issue:

Versions:

  • Go Version: 1.21.3
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.2
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

Copy link

cloudflare-workers-and-pages bot commented Nov 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: dc61346
Status: ✅  Deploy successful!
Preview URL: https://a3ed0b60.vald.pages.dev
Branch Preview URL: https://feature-make-add-minikube.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Nov 6, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@ykadowak ykadowak force-pushed the feature/make/add-minikube branch from 16e7ea5 to dc61346 Compare November 6, 2023 07:42
@ykadowak ykadowak changed the title [WIP] Add minikube to create volume snapshot development environment locally Add minikube to create volume snapshot development environment locally Nov 6, 2023
@ykadowak ykadowak requested review from a team, kpango and hlts2 and removed request for a team November 6, 2023 08:01
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ykadowak ykadowak merged commit 248a82a into main Nov 6, 2023
28 checks passed
@ykadowak ykadowak deleted the feature/make/add-minikube branch November 6, 2023 08:05
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
@vankichi vankichi mentioned this pull request Dec 4, 2023
kmrmt pushed a commit that referenced this pull request Dec 12, 2023
#2228)

* Add minikube to create volume snapshot development environment locally

* Fix devcontainer build

* Add triggers for devcontainer build

* apply format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants