Skip to content

Commit

Permalink
Revert "Add minikube to create volume snapshot development environmen…
Browse files Browse the repository at this point in the history
…t locally (#2228)"

This reverts commit 248a82a.
  • Loading branch information
ykadowak committed Nov 30, 2023
1 parent b9b58a5 commit 37be959
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 59 deletions.
15 changes: 3 additions & 12 deletions .github/workflows/dockers-dev-container-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,31 +22,22 @@ on:
- ".github/actions/docker-build/actions.yaml"
- ".github/workflows/_docker-image.yaml"
- ".github/workflows/dockers-dev-container-image.yml"
- "dockers/ci/**"
- "dockers/dev/**"
- "Makefile"
- "Makefile.d/**"
- "versions/GO_VERSION"
- "versions/NGT_VERSION"
pull_request:
paths:
- ".github/actions/docker-build/actions.yaml"
- ".github/workflows/_docker-image.yaml"
- ".github/workflows/dockers-dev-container-image.yml"
- "dockers/ci/**"
- "dockers/dev/**"
- "Makefile"
- "Makefile.d/**"
- "versions/GO_VERSION"
- "versions/NGT_VERSION"
pull_request_target:
paths:
- ".github/actions/docker-build/actions.yaml"
- ".github/workflows/_docker-image.yaml"
- ".github/workflows/dockers-dev-container-image.yml"
- "dockers/ci/**"
- "dockers/dev/**"
- "Makefile"
- "Makefile.d/**"
- "versions/GO_VERSION"
- "versions/NGT_VERSION"
schedule:
- cron: "0 1 * * *"

Expand Down
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -579,4 +579,3 @@ include Makefile.d/kind.mk
include Makefile.d/proto.mk
include Makefile.d/test.mk
include Makefile.d/tools.mk
include Makefile.d/minikube.mk
42 changes: 0 additions & 42 deletions Makefile.d/minikube.mk

This file was deleted.

6 changes: 4 additions & 2 deletions Makefile.d/proto.mk
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ proto/deps: \
$(GOPATH)/src/github.com/planetscale/vtprotobuf \
$(GOPATH)/src/github.com/protocolbuffers/protobuf \
$(GOPATH)/src/google.golang.org/genproto \
$(GOPATH)/src/google.golang.org/protobuf
$(GOPATH)/src/google.golang.org/protobuf \
$(ROOTDIR)/apis/proto/v1/rpc/error_details.proto

.PHONY: proto/clean/deps
## uninstall all protobuf dependencies
Expand All @@ -78,7 +79,8 @@ proto/clean/deps:
$(GOPATH)/src/github.com/planetscale/vtprotobuf \
$(GOPATH)/src/github.com/protocolbuffers/protobuf \
$(GOPATH)/src/google.golang.org/genproto \
$(GOPATH)/src/google.golang.org/protobuf
$(GOPATH)/src/google.golang.org/protobuf \
$(ROOTDIR)/apis/proto/v1/rpc/error_details.proto


$(GOPATH)/src/github.com/protocolbuffers/protobuf:
Expand Down
3 changes: 1 addition & 2 deletions dockers/dev/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,4 @@ RUN make deps \
# additional deps
RUN make k3d/install \
&& make buf/install \
&& make k9s/install \
&& make minikube/install
&& make k9s/install

0 comments on commit 37be959

Please sign in to comment.