Add read replica rotator #2241
Merged
Add read replica rotator #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[WARNING:INTCFG] Changes in |
|
[CHATOPS:HELP] ChatOps commands.
|
ykadowak
changed the title
datelier
previously approved these changes
Nov 27, 2023
vankichi
requested changes
Nov 28, 2023
| Observability *config.Observability `json:"observability" yaml:"observability"` | ||
|
|
||
| // TODO: | ||
| ReadreplicaRotate *config.ReadreplicaRotate `json:"rotator" yaml:"rotator"` |
There was a problem hiding this comment.
Suggested change
| ReadreplicaRotate *config.ReadreplicaRotate `json:"rotator" yaml:"rotator"` | |
| ReadReplicaRotate *config.ReadreplicaRotate `json:"rotator" yaml:"rotator"` |
🤔 ?
Comment on lines
+56
to
+59
| if replicaID == "" { | ||
| return nil, fmt.Errorf("readreplica id is empty. it should be set via MY_TARGET_REPLICA_ID env var") | ||
| } | ||
| r.readReplicaID = replicaID |
There was a problem hiding this comment.
It would be better to use functional options e.g. func() WithReplicaID(id string) error {}
There was a problem hiding this comment.
Because replicaID is mandatory. Let's merge this first and discuss it later.
vankichi
approved these changes
Nov 28, 2023
datelier
approved these changes
Nov 29, 2023
2 tasks
Merged
kmrmt
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Implement sample read replica rotation logic * Add external-snapshotter in go.mod * Add readreplica initial implementation * Add service implementation of readreplica rotator * Add readreplica rotate config * Refactor to read labels * replace id to _MY_TARGET_REPLICA_ID_ * Add snapshot k8s client * Format * Fix snapshot client initialization * Add Apache License to main.go * Use GetConfigOrDie * Use internal/k8s client * Refactor * Use controller-runtime for CRUD in readreplica * Remove snapshot client and use controller-runtime * Move LabelSelector into internal/k8s * Report error to span * Update go modules * Remove old example * Refactor * Disable exhaustruct for now * Fix predeclared * Fix stylecheck * nolint:gomnd * Add test template * Add test for getNewBaseName * fix misspelling * Apply format * Fix camel case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements read replica rotation algorithm. Tests will be added when job is implemented after this PR.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: