Add job error to report index correction error status #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
Deploying with
|
| Latest commit: |
99edb2c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://35bae172.vald.pages.dev |
| Branch Preview URL: | https://feature-job-correction-refac.vald.pages.dev |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention:
... and 4 files with indirect coverage changes 📢 Thoughts on this report? Let us know! |
StartMonitoring for clearity
ykadowak
requested review from
hlts2,
a team and
vankichi
and removed request for
a team
ykadowak
changed the title
vankichi
previously approved these changes
Nov 8, 2023
hlts2
reviewed
Nov 8, 2023
hlts2
reviewed
Nov 8, 2023
ykadowak
force-pushed
the
feature/job/correction-refactor
branch
from
4d13235 to
5f0a887
Compare
Profile Report
|
vankichi
approved these changes
Nov 9, 2023
Merged
kmrmt
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Fix to monitor discoverer error for index correction * Add errors.RemoveDuplicates * Add jobErrs to report job status of index correction * Simplify function literal * Update Corrector interface method name to StartMonitoring for clearity * Removed unnecessary error handling * Update Corrector interface method name to StartClient * Fix error handling in corrector.go to catch all the err in defer function --------- Co-authored-by: Kiichiro YUKAWA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates
index correctionin two ways,correctfunction. Also made changes in some cases not to continue processing but just stop processing and report errors.Related Issue:
Versions:
Checklist:
Special notes for your reviewer: