Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document for RemoveByTimestamp RPC #2238

Merged
merged 10 commits into from
Nov 24, 2023
Merged

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Nov 21, 2023

Description:

I added RemoveByTimestamp RPC previously, but the documentation was not included, so I added it.

Related Issue:

Versions:

  • Go Version: 1.21.3
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.2
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

@hlts2 hlts2 self-assigned this Nov 21, 2023
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

This commit fixes the style issues introduced in 29b94da according to the output
from Gofumpt and Prettier.

Details: #2238
Copy link

cloudflare-workers-and-pages bot commented Nov 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3996a08
Status: ✅  Deploy successful!
Preview URL: https://3f9e1797.vald.pages.dev
Branch Preview URL: https://documentation-docs-add-rpc.vald.pages.dev

View logs

docs/api/remove.md Show resolved Hide resolved
docs/api/remove.md Show resolved Hide resolved
@hlts2 hlts2 requested review from a team, vankichi and ykadowak and removed request for a team November 21, 2023 05:57
ykadowak
ykadowak previously approved these changes Nov 21, 2023
This commit fixes the style issues introduced in cd02e4f according to the output
from Gofumpt and Prettier.

Details: #2238
ykadowak
ykadowak previously approved these changes Nov 22, 2023
docs/api/remove.md Outdated Show resolved Hide resolved
@hlts2 hlts2 requested a review from ykadowak November 24, 2023 04:10
@vankichi vankichi merged commit dd952e6 into main Nov 24, 2023
87 checks passed
@vankichi vankichi deleted the documentation/docs/add-rpc branch November 24, 2023 05:16
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
@vankichi vankichi mentioned this pull request Dec 4, 2023
kmrmt pushed a commit that referenced this pull request Dec 12, 2023
* feat: add document for RemoveByTimestamp rpc

Signed-off-by: hlts2 <[email protected]>

* fix: add comment to enum value

Signed-off-by: hlts2 <[email protected]>

* fix: refactor document

Signed-off-by: hlts2 <[email protected]>

* fix: make proto/all format

Signed-off-by: hlts2 <[email protected]>

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in 29b94da according to the output
from Gofumpt and Prettier.

Details: #2238

* feat: add notice section to removeByTimestamp arpc

Signed-off-by: hlts2 <[email protected]>

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in cd02e4f according to the output
from Gofumpt and Prettier.

Details: #2238

* Update docs/api/remove.md

---------

Signed-off-by: hlts2 <[email protected]>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants