Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0 release todo #3731

Closed
28 of 32 tasks
soullivaneuh opened this issue Apr 20, 2016 · 51 comments
Closed
28 of 32 tasks

3.0.0 release todo #3731

soullivaneuh opened this issue Apr 20, 2016 · 51 comments

Comments

@soullivaneuh
Copy link
Member

soullivaneuh commented Apr 20, 2016

Issue updated since #3731 (comment):
This will not be 2.4 but 3.0. See reasons:

  • dev-master has already several BC breaking modifications that was merged (sigh)
  • Pushing a major release would prevent other stable sonata bundle to auto-update to the new version and might be failed
  • This will be the occasion to make a real separation between the old and the new versions management

Since this time, if you're requiring sonata-project/admin-bundle 2.4.*@dev on composer.json, you have to change to 3.*@dev, 3.x-dev@dev or dev-master@dev.
This is the only breaking change.

For possible dependencies issues, see #3731 (comment).

PLEASE DO NOT POST YOUR DEPENDENCIES ISSUES HERE

This issue is not here for that. If you tried previous solutions and are still stuck, please open another issue on the concerned project.

Even if it's a new major, no BC breaking Pull Request will be merge until 3.0.0 release.
The reason is simple: Lot of user are already using dev-master version of sonata-admin and we didn't tag minor/major releases from a long time. Let's do it painless.

This issue goal is to list all to do things that we must do before and after tag this version.

To many changes between 2.3 and master branch, we have to take precaution.

This issue will be a model for another repository minor tag before start the new release process management.

Before tagging

Internal changes

Internal dependencies issues

List etablished from composer show --all sonata-project/*.
Not all packages need to be updated.

Tagging

  • Tag the v3.0.0 release. Rofl.

After Tagging

Related bundles stable releases

  • [ ]

Misc

  • Remove 2.0 -> 2.2 branches
  • Move 2.3 to 2.x branch (just for history, no modification will be allowed).
  • Create a 3.x branch => For minor releases
  • Closes all PR concerning patch or minor modification with a message to tell user to rebase it on 3.x
  • Do a "We are very glad that finally happenned!" tweet. 🎉

Am I missing something? Tell me! 👍

Tagged project

@Koc
Copy link
Contributor

Koc commented Apr 20, 2016

@OskarStark
Copy link
Member

ping @mvhirsch

@javiereguiluz
Copy link
Contributor

@soullivaneuh what about signing the new v2.4.0 tag? Reference

@javiereguiluz
Copy link
Contributor

javiereguiluz commented Apr 20, 2016

@soullivaneuh another suggestion: prepare a "curated" changelog of the main features and bug fixes introduced by the new version.

@mvhirsch
Copy link
Contributor

What about updating the documentation for 2.4?

@ju1ius
Copy link
Contributor

ju1ius commented Apr 20, 2016

Closes all PR concerning patch or minor modification with a message to tell user to rebase it on 2.x

@soullivaneuh I would say do not close right away. Label the issue as outdated, send a message to author telling authors to rebase and that the issue will be closed in a given time frame if they don't. And encourage them to close it by themselves if they don't intend to work on it any further (or the issue has been fixed since).

People tend to get angry when their PR/tickets receive no response for months, then is abruptly closed because the version changes.

@ju1ius
Copy link
Contributor

ju1ius commented Apr 20, 2016

@Koc I would say 👎 for merging #3258 in 2.4

The idea is great but there's a big responsiveness problem with the current top nav layout that can't be fixed in a BC way.
Basically, we first need to move the breadcrumb from the top bar to the main body, because a breadcrumb has by definition a potentially infinite length, and in a fixed appbar everything must fit on one line.
Then #3258 can be merged easilly, and make the breadcrumb component kick asses.

@soullivaneuh
Copy link
Member Author

After discussing with @rande and @sonata-project/contributors we decided to not push a minor release but a major one.

So it will not be 2.4.0 but 3.0.0.

For some reasons:

  • dev-master has already several BC breaking modifications that was merged (sigh)
  • Pushing a major release would prevent other stable sonata bundle to auto-update to the new version and might be failed
  • This will be the occasion to make a real separation between the old and the new versions management

I'll update the issue accordingly, with corresponding warns.

@soullivaneuh soullivaneuh changed the title 2.4.0 release todo 3.0.0 release todo Apr 20, 2016
@soullivaneuh
Copy link
Member Author

@soullivaneuh another suggestion: prepare a "curated" changelog of the main features and bug fixes introduced by the new version.

Yeah, I think we should create a new clear changelog starting from 3.0.

@soullivaneuh
Copy link
Member Author

What about updating the documentation for 2.4?

2.4 -> 3.0

What do you mean?

@core23
Copy link
Member

core23 commented Apr 20, 2016

[ ] Move tickets from milestones to > 3.0 / 4.0

@soullivaneuh
Copy link
Member Author

I would say do not close right away. Label the issue as outdated, send a message to author telling authors to rebase and that the issue will be closed in a given time frame if they don't.

@ju1ius I would see on a reverse way: people would reopen a pr if they want to continue.

In your way, we will have a lot of PR without continuing work but still open on the list. It's hard, but we will have a new and clean start.

ping @rande and @sonata-project/contributors for opinion.

People tend to get angry when their PR/tickets receive no response for months, then is abruptly closed because the version changes.

We just have to explain clearly why we are doing this. Sebastian did this for PHPUnit and it works great AFAIK.

For #3731 (comment), this is not related to this issue. Please comment on the related PR.

@soullivaneuh
Copy link
Member Author

[ ] Move tickets from milestones to > 3.0 / 4.0

I think we will reset the milestones at all.

@ju1ius
Copy link
Contributor

ju1ius commented Apr 20, 2016

We just have to explain clearly why we are doing this. Sebastian did this for PHPUnit and it works great AFAIK.

Yes explaining is key.
I had the GNOME project in mind with their habit to automatically close every ticket that was submitted against an old version. More often than not the bug is still present and it leads to issues staying unresolved for years. It really pisses people off and discourage them to submit bugs and patches, which is a shame.

@soullivaneuh
Copy link
Member Author

@ju1ius I understand your point of view. I still think we should do the closing way.

This is a kind of sacrifice, but we have to cleanup to have a good see of what to do for the future.

soullivaneuh added a commit to soullivaneuh/SonataAdminBundle that referenced this issue Apr 20, 2016
soullivaneuh added a commit that referenced this issue Apr 20, 2016
soullivaneuh added a commit to soullivaneuh/SonataAdminBundle that referenced this issue Apr 20, 2016
Old planned version was 2.4. It's now 3.0.

See why on sonata-project#3731.
soullivaneuh added a commit that referenced this issue Apr 20, 2016
Old planned version was 2.4. It's now 3.0.

See why on #3731.
@soullivaneuh
Copy link
Member Author

@Avtonom just see #3731 (comment) and #3732.

@Avtonom
Copy link

Avtonom commented Apr 20, 2016

@soullivaneuh, thanks for the tip! I not immediately caught the depth changes.
How do I fix it?
sonata-project/classification-bundle 2.3.x-dev requires sonata-project/admin-bundle ~2.4 -> no matching package found

@soullivaneuh
Copy link
Member Author

We are almost here! 🎉

All packages are now updated except 3 of them.

I closes this one in favor of dev-kit one: sonata-project/dev-kit#140

Thanks all for your support about this new adventure! 👯 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests