Autcomplete feature #149
Autcomplete feature #149
Conversation
joshlopes
commented
Sep 16, 2015
joshlopes
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | ? |
| Deprecations? | ? |
| Tests pass? | ? |
| Fixed tickets | |
| License | yes |
| Doc PR | yes |
…hAdmiClass on the fixFieldDescription as ORM -- Added getFieldName on Filter to respect the parents associations mappings
Conflicts: Builder/DatagridBuilder.php Filter/ModelFilter.php composer.json
Yes, new tools under testing. Check for Travis for now. CS need to be fixed, please rebase your PR to make travis green. |
| @@ -116,6 +121,16 @@ public function addFilter(DatagridInterface $datagrid, $type = null, FieldDescri | |||
| $admin->addFilterFieldDescription($fieldDescription->getName(), $fieldDescription); | |||
|
|
|||
| $fieldDescription->mergeOption('field_options', array('required' => false)); | |||
|
|
|||
| if ($type === 'doctrine_mongo_autocomplete') { | |||
|
@soullivaneuh done. |
| @@ -19,17 +19,35 @@ | |||
| protected $active = false; | |||
|
|
|||
| /** | |||
| * {@inheritdoc} | |||
| * @param mixed $queryBuilder | |||
There was a problem hiding this comment.
No reason, should i put it back ?
There was a problem hiding this comment.
Of course. If this method as a parent, it must have this tag.
|
According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning. If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch. So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one). Regards. |
