[Templating] [Twig] Sf3.0 support : Changing render from tag to function #154
Conversation
| "doctrine/mongodb-odm-bundle": "~3.0", | ||
| "doctrine/mongodb-odm": "~1.0", | ||
| "sonata-project/admin-bundle": "~2.3" | ||
| "doctrine/mongodb-odm-bundle": "~3.0@dev", |
There was a problem hiding this comment.
It shouldn't depend of dev dependencies (same below).
There was a problem hiding this comment.
In that case, there should be some releases of this bundle or some develop branch since it's not great also in projects depend on master of this bundle.
| @@ -18,8 +18,8 @@ | |||
| ], | |||
| "require": { | |||
| "doctrine/mongodb-odm-bundle": "~3.0", | |||
| "doctrine/mongodb-odm": "~1.0", | |||
| "sonata-project/admin-bundle": "~2.3" | |||
| "sonata-project/admin-bundle": "~2.3.0", | |||
There was a problem hiding this comment.
Well this will fail with symfony3, I would expect that master branch will support symfony3.
Also this template change should break symfony <2.6
There was a problem hiding this comment.
~2.3 will result in fetching dev-master or 2.4.x-dev which are the same.
Anyway, if not fetching 2.4.x-dev travis tests on 3.0 result in an error because SonataAdmin still uses Symfony\Component\Validator\ValidatorInterface; in 2.3.x instead of Symfony\Component\Validator\Validator\ValidatorInterface;.
So either we target a dev version of SonataAdminBundle or we wait for 2.4.x-dev to release a stable version.
There was a problem hiding this comment.
IMO the best option is to wait for a new stable release of SonataAdminBundle.
|
Could you please rebase your PR and fix merge conflicts? |
|
According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning. If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch. So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one). Regards. |
|
The issue still happens with: Is there a way to work around the issue ? |
|
See #182 |
|
If i'm understanding correctly, someone has to do the PR? Right? |
|
It's more about cleaning the existing PR. Would you like to do it? |
|
Yeah sure. |
Creating another PR is the only way I know of. You can't access #182 unless the authors gives you right on his repo. |
|
Ok, tell me if I did the right thing. |
The main problem with your PR is that you completely removed the PR template when submitting it. Was it intentional? |
|
I updated it. Hope it's better. |
Since Sf3.0 Twig
rendertag became a function.Updated some templates that were using render as a tag.