Correct use of render function for Symfony greater than 2.6 #188

jeantristan · 2016-08-02T15:49:46Z

I'm targeting branch 3.x cause it's a bugfix.
However it's not BC compatible with all symfony2 versions.

Fixes : No open issues.
(Do i have to open an issue to make a reference ?)

Changelog

### Fixed
- call of render function now Sf3 compatible

Subject

Change from a render tag to a render function

greg0ire · 2016-08-02T15:50:41Z

Please don't just ignore the PR template, it's one of the main problem with the #182.

greg0ire · 2016-08-02T15:53:04Z

Resources/views/Form/form_admin_fields.html.twig

@@ -51,11 +51,11 @@ file that was distributed with this source code.
        <span id="field_actions_{{ id }}" class="field-actions">
            <span id="field_widget_{{ id }}" class="field-short-description">
                {% if sonata_admin.field_description.associationadmin.id(sonata_admin.value) %}
-                    {% render url('sonata_admin_short_object_information', {
+                    {% render(url('sonata_admin_short_object_information', {


If you don't use display tags like in #182, I'm afraid this won't do anything.

greg0ire · 2016-08-02T16:08:26Z

Resources/views/Form/form_admin_fields.html.twig

@@ -51,12 +51,12 @@ file that was distributed with this source code.
        <span id="field_actions_{{ id }}" class="field-actions">
            <span id="field_widget_{{ id }}" class="field-short-description">
                {% if sonata_admin.field_description.associationadmin.id(sonata_admin.value) %}
-                    {% render url('sonata_admin_short_object_information', {
+                    {{ render (url('sonata_admin_short_object_information', {


No space between the function name and the parenthesis please.

greg0ire · 2016-08-02T16:25:11Z

Do you know what I'm talking about when I say PR template ? It is the piece of text that was in the textarea when you submitted the PR. You can still edit your PR to fill it, here is what the template looks like : https://raw.githubusercontent.com/sonata-project/SonataDoctrineMongoDBAdminBundle/3.x/.github/PULL_REQUEST_TEMPLATE.md

greg0ire · 2016-08-02T16:26:53Z

Also, some repos have a CONTRIBUTING.md, and link to it appears when you submit your PR. Make sure you read ours

jeantristan · 2016-08-02T16:43:25Z

Ok thanks. I updated my PR using PR template.
I have some questions:

I don't know if it's BC compatible or not ?
Do i have to open an issue to reference it in the PR ?
Do i have to update the tests?

greg0ire · 2016-08-02T17:33:19Z

Ok thanks. I updated my PR using PR template.

It's better.

This is backwards compatible IMO : the render() function exists in 2.3
Do i have to open an issue to reference it in the PR ? No
Do i have to update the tests? No you don't.

greg0ire · 2016-08-02T17:35:02Z

~~LGTM~~ I added some comments, so you have to fix them first, and then your commit message has to be changed, either by the person who will merge this, or by yourself (git commit --amend, git push --force).

Here is what I suggest :

Replace deprecated render tag with function

greg0ire · 2016-08-02T17:39:24Z

So to sum up, here is your todo list :

Correct use of render function for Symfony greater than 2.6 #188 (comment)

greg0ire · 2016-08-02T19:13:18Z

Resources/views/Form/form_admin_fields.html.twig

@@ -55,8 +55,7 @@ file that was distributed with this source code.
                        'code':     sonata_admin.field_description.associationadmin.code,
                        'objectId': sonata_admin.field_description.associationadmin.id(sonata_admin.value),
                        'uniqid':   sonata_admin.field_description.associationadmin.uniqid
-                        })
-                    )}}
+                        })) }}


Almost there : indent this to the left once and it will be perfect!

Could you tell me, how am I supposed to know it?
I did not read it in PSR-2 / PSR-1 or Symfony coding standards.
It's just to avoid to make any new mistake

It's not php, so nothing to do with the PSR, but indention means that just like you indent content inside a hash, like this :

{% set my hash = { 'item1', 'item2', 'item3' } %} you have to do it no matter where the hash is (in our case, inside a function call).

jeantristan · 2016-08-02T19:23:31Z

comment Correct use of render function for Symfony greater than 2.6 #188
change commit message -> In order to do it, do i have to do another PR? Sorry to bother, I don't know the process.

greg0ire · 2016-08-02T19:26:02Z

In order to do it, do i have to do another PR? Sorry to bother, I don't know the process.

Oh I see what you did. You need to learn how to rebase (see CONTRIBUTING.md), so that you can produce one commit with the right message.

But don't bother, just fix this, I'll take care of making one commit with the right message, I can do it when merging.

greg0ire · 2016-08-02T19:32:51Z

Finally good! I'll merge as soon as the build is ok, thanks a lot!

jeantristan · 2016-08-02T19:37:21Z

Next time, I'll do better ;-)

greg0ire · 2016-08-02T19:57:41Z

Thanks @jeantristan !

Update form_admin_fields.html.twig

46f9ce2

SonataCI added the review required label Aug 2, 2016

jeantristan mentioned this pull request Aug 2, 2016

[Templating] [Twig] Sf3.0 support : Changing render from tag to function #154

Closed

greg0ire reviewed Aug 2, 2016
View reviewed changes

Update form_admin_fields.html.twig

4992db3

greg0ire reviewed Aug 2, 2016
View reviewed changes

Update form_admin_fields.html.twig

ea20ffb

greg0ire added the pending author label Aug 2, 2016

Replace deprecated render tag with function

a2b5627

SonataCI removed the pending author label Aug 2, 2016

greg0ire reviewed Aug 2, 2016
View reviewed changes

Fix indendation

b95eb08

greg0ire merged commit 7b3a9f7 into sonata-project:3.x Aug 2, 2016

greg0ire added RTM pedantic patch and removed review required pedantic labels Aug 2, 2016

This was referenced Aug 2, 2016

Problem with "unexpected render tag" #181

Closed

Correct use of render function for Symfony greater than 2.6 #182

Closed

OskarStark removed the RTM label Aug 21, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correct use of render function for Symfony greater than 2.6 #188

Correct use of render function for Symfony greater than 2.6 #188

jeantristan commented Aug 2, 2016 •

edited by OskarStark

Loading

greg0ire commented Aug 2, 2016 •

edited

Loading

greg0ire Aug 2, 2016

greg0ire Aug 2, 2016

greg0ire commented Aug 2, 2016

greg0ire commented Aug 2, 2016

jeantristan commented Aug 2, 2016

greg0ire commented Aug 2, 2016

greg0ire commented Aug 2, 2016 •

edited

Loading

greg0ire commented Aug 2, 2016 •

edited

Loading

greg0ire Aug 2, 2016

jeantristan Aug 2, 2016

greg0ire Aug 2, 2016

jeantristan commented Aug 2, 2016

greg0ire commented Aug 2, 2016 •

edited

Loading

greg0ire commented Aug 2, 2016

jeantristan commented Aug 2, 2016

greg0ire commented Aug 2, 2016

Correct use of render function for Symfony greater than 2.6 #188

Correct use of render function for Symfony greater than 2.6 #188

Conversation

jeantristan commented Aug 2, 2016 • edited by OskarStark Loading

Changelog

Subject

greg0ire commented Aug 2, 2016 • edited Loading

greg0ire Aug 2, 2016

Choose a reason for hiding this comment

greg0ire Aug 2, 2016

Choose a reason for hiding this comment

greg0ire commented Aug 2, 2016

greg0ire commented Aug 2, 2016

jeantristan commented Aug 2, 2016

greg0ire commented Aug 2, 2016

greg0ire commented Aug 2, 2016 • edited Loading

greg0ire commented Aug 2, 2016 • edited Loading

greg0ire Aug 2, 2016

Choose a reason for hiding this comment

jeantristan Aug 2, 2016

Choose a reason for hiding this comment

greg0ire Aug 2, 2016

Choose a reason for hiding this comment

jeantristan commented Aug 2, 2016

greg0ire commented Aug 2, 2016 • edited Loading

greg0ire commented Aug 2, 2016

jeantristan commented Aug 2, 2016

greg0ire commented Aug 2, 2016

jeantristan commented Aug 2, 2016 •

edited by OskarStark

Loading

greg0ire commented Aug 2, 2016 •

edited

Loading

greg0ire commented Aug 2, 2016 •

edited

Loading

greg0ire commented Aug 2, 2016 •

edited

Loading

greg0ire commented Aug 2, 2016 •

edited

Loading