add ClonePagesCommand #514
Conversation
| $blockClones = array(); | ||
|
|
||
| // TODO: check if we are missing parents | ||
| $output->writeln('Cloning pages'); |
|
Can you explain a little bit your feature? Some sample would be great. Also documentation need to be updated. |
|
@soullivaneuh doc is in the RFC, and this is pretty rough stuff still |
|
Didn't see the link, my bad. CS need to be fixed. BTW, indent should be 4 spaces, not 2. You can solve CS quickly with https://travis-ci.org/sonata-project/SonataPageBundle/jobs/73343238#L369 |
| * {@inheritdoc} | ||
| */ | ||
| public function configure() { | ||
| $this->setName( 'sonata:page:clone' ); |
There was a problem hiding this comment.
No spaces between parenthesis.
| */ | ||
| class ClonePagesCommand extends BaseCommand | ||
| { | ||
| /** |
| $output->writeln(sprintf(' cloning block % 4s ', $block->getId())); | ||
| $newBlock = clone $block; | ||
| $newBlock->setPage($newPage); | ||
| $blockClones[ $block->getId() ] = $newBlock; |
|
Also a related test files should be written. I'll let @rande manage this PR after code review. |
| $this->setName('sonata:page:clone'); | ||
| $this->setDescription('Clone pages'); | ||
| $this->addOption('sourcesite', null, InputOption::VALUE_REQUIRED, 'Source Site id', null); | ||
| $this->addOption('destsite', null, InputOption::VALUE_REQUIRED, 'Dest Site id', null); |
There was a problem hiding this comment.
IMO dest-site would be better
| $source_site = $this->getSiteManager()->findBy(array('id' => $input->getOption('sourcesite'))); | ||
| $dest_site = $this->getSiteManager()->findBy(array('id' => $input->getOption('destsite'))); | ||
|
|
||
| $pages = $this->getPageManager()->findBy(array('site' => $source_site[0])); |
There was a problem hiding this comment.
would use findOneBy() as we can use $source_site variable directly instead of $source_site[0]
|
@koyaan would you please apply our comments? We would really like this feature merged 😄 |
|
Tests for the new command should be added. |
|
Please keep on working on this 👍 @koyaan |
|
According to the new Sonata version management and next major release plan, this project has been refactored regarding branching and versioning. If you see this message, your PR concerns a patch or a minor release and is not targeting the right branch. So I'm closing this one, but don't see it as a refusal. If you think your work is still relevant and want to continue, feel free to reopen it on the right branch (e.g. the default one). Regards. |
Never did get around to refactor this into services unfortunately