Composer improvements #370
Conversation
soullivaneuh
commented
May 2, 2016
soullivaneuh
commented
- 2.x-dev
- Use new composer constraints notation
- Remove minimum stability
* 2.x-dev * Use new composer constraints notation * Remove minimum stability
| "symfony-cmf/tree-browser-bundle": "~2.0", | ||
| "symfony-cmf/resource-rest-bundle": "~1.0" | ||
| "php": "^5.5 || ^7.0", | ||
| "sonata-project/admin-bundle": "3.x-dev@dev", |
There was a problem hiding this comment.
same question here, why not 3.*?
There was a problem hiding this comment.
This should at least be ^3.0@dev and not 3.x-dev@dev (which is double btw, 3.x-dev should be enough).
There was a problem hiding this comment.
3.x-dev@dev looks indeed fishy…
| "doctrine/phpcr-bundle": "~1.1", | ||
| "symfony-cmf/tree-browser-bundle": "~2.0", | ||
| "symfony-cmf/resource-rest-bundle": "~1.0" | ||
| "php": "^5.5 || ^7.0", |
There was a problem hiding this comment.
any reason to use || instead of the quite common |?
There was a problem hiding this comment.
instead of the quite common
|?
This is the problem: it shouldn't.
|| is the new standard. See examples on docs: https://getcomposer.org/doc/04-schema.md
There was a problem hiding this comment.
Thanks for the info, good to know that the single one is actually sort-of deprecated.
|
LGTM, CMF is blocked by this atm. This is precisely why small, scoped PRs are better than large ones. If just the |
|
@wouterj Just two points:
|
|
see #371 |
