Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer fixes and improves #183

Merged
merged 2 commits into from
Apr 21, 2016

Conversation

soullivaneuh
Copy link
Member

@soullivaneuh soullivaneuh commented Apr 21, 2016

THIS BUNDLE WILL HAVE A NEW MAJOR RELEASE

  • 3.x-dev
  • Use new composer constraints notation
  • Remove minimum-stability option to clearly show which required packages are not stable

* 3.x-dev
* Use new composer constraints notation
* Remove minimum-stability option to clearly show which required packages are not stable
@soullivaneuh soullivaneuh merged commit b1a522d into sonata-project:master Apr 21, 2016
@soullivaneuh soullivaneuh deleted the composer-fix branch April 21, 2016 08:20
},
"suggest": {
"sonata-project/media-bundle": "~2.2"
"sonata-project/media-bundle": "^2.2"
Copy link
Member

@core23 core23 Apr 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggest property should contain text, no version number https://getcomposer.org/doc/04-schema.md#suggest

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but this is not the goal of the PR and not the priority right now. :-)

Feel free to open a PR and ping me for suggestion. 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Have versions on conflicts key would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants