Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer improvements #3751

Merged
merged 2 commits into from
May 1, 2016

Conversation

soullivaneuh
Copy link
Member

  • Use new composer constraints notation
  • Add missing PHP constraint
  • New sonata project majors requiring

* Use new composer constraints notation
* Add missing PHP constraint
* New sonata project majors requiring
@soullivaneuh soullivaneuh self-assigned this May 1, 2016
@soullivaneuh soullivaneuh mentioned this pull request May 1, 2016
32 tasks
@soullivaneuh
Copy link
Member Author

@sonata-project/contributors Can anyone explains me this issue? https://travis-ci.org/sonata-project/SonataAdminBundle/jobs/127012710#L554

@soullivaneuh soullivaneuh merged commit 19945d3 into sonata-project:master May 1, 2016
@soullivaneuh soullivaneuh deleted the composer-improve branch May 1, 2016 13:11
"symfony/yaml": "~2.3|~3.0",
"jms/di-extra-bundle": "^1.7",
"sensio/generator-bundle": "^2.3 || ^3.0",
"symfony/yaml": "^2.3 || ^3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the sort-package option in all composer.json of all sonata-projects would be great.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What sort-package option does exactly?

Copy link
Contributor

@greg0ire greg0ire May 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sorts all packages alphabetically, but this works with composer require only. https://getcomposer.org/doc/06-config.md#sort-packages

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it works with composer validate too?

Can be discussed on a sonata-project/dev-kit issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it works with composer validate too?

I tested that, but no, validate does not report anything about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants